Re: [PATCH v47 00/19] hw/sd/sdcard: Add eMMC support

[Cédric Le Goater]

On 7/9/24 5:25 PM, Philippe Mathieu-Daudé wrote:
> Since v42:
> - Stick to spec v4.3 (re-simplified EXT_CSD register & migrate)
> - Fill CID register
> - Few changes to CSD register
> - Implement 'boot-mode' reset timing
> - Add 'boot-size' property
>
> Change required for aspeed branch:
> -- >8 --
> diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
> index 8c0e36badd..563816b710 100644
> --- a/hw/arm/aspeed.c
> +++ b/hw/arm/aspeed.c
> @@ -344,3 +344,3 @@ static void sdhci_attach_drive(SDHCIState *sdhci, DriveInfo 
> *dinfo, bool emmc,
>           if (emmc) {
> -            qdev_prop_set_uint8(card, "boot-config", boot_emmc ? 0x48 : 0x0);
> +            qdev_prop_set_uint64(card, "boot-size", 1 * MiB);
>           }
> (I'm still reluctant to merge patches 16-18)...

Then, please drop all changes related to the boot partitions. I will keep
the original patches in my tree and address the feature when I have time.
TYPE_EMMC is already great to have.

Thanks,

C.



> ---
>
> Cédric Le Goater (2):
>    hw/sd/sdcard: Add emmc_cmd_SET_RELATIVE_ADDR handler (CMD3)
>    hw/sd/sdcard: Fix SET_BLOCK_COUNT command argument on eMMC (CMD23)
>
> Joel Stanley (3):
>    hw/sd/sdcard: Support boot area in emmc image
>    hw/sd/sdcard: Subtract bootarea size from blk
>    hw/sd/sdcard: Add boot config support
>
> Luc Michel (1):
>    hw/sd/sdcard: Implement eMMC sleep state (CMD5)
>
> Philippe Mathieu-Daudé (11):
>    hw/sd/sdcard: Basis for eMMC support
>    hw/sd/sdcard: Register generic command handlers
>    hw/sd/sdcard: Register unimplemented command handlers
>    hw/sd/sdcard: Implement emmc_set_cid()
>    hw/sd/sdcard: Implement emmc_set_csd()
>    hw/sd/sdcard: Add mmc_cmd_PROGRAM_CID handler (CMD26)
>    hw/sd/sdcard: Add eMMC 'boot-size' property
>    hw/sd/sdcard: Simplify EXT_CSD values for spec v4.3
>    hw/sd/sdcard: Migrate ExtCSD 'modes' register
>    hw/sd/sdcard: Implement eMMC 'boot-mode'
>    hw/sd/sdcard: Enable TYPE_EMMC card model
>
> Sai Pavan Boddu (1):
>    hw/sd/sdcard: Add mmc SWITCH function support (CMD6)
>
> Vincent Palatin (1):
>    hw/sd/sdcard: Add emmc_cmd_SEND_EXT_CSD handler (CMD8)
>
>   include/hw/sd/sd.h |   4 +
>   hw/sd/sd.c         | 424 ++++++++++++++++++++++++++++++++++++++++++++-
>   hw/sd/trace-events |   3 +
>   3 files changed, 425 insertions(+), 6 deletions(-)