Re: [PATCH v3 2/5] block: move commit_run loop to separate function

qemu-block

From:	Vladimir Sementsov-Ogievskiy
Subject:	Re: [PATCH v3 2/5] block: move commit_run loop to separate function
Date:	Mon, 30 Sep 2024 16:57:24 +0300
User-agent:	Mozilla Thunderbird

On 01.09.24 17:24, Vincent Vanlaer wrote:

+static int commit_iteration(CommitBlockJob *s, int64_t offset, int64_t *n, 
void *buf) {


Hmm over-80 line. Didn't you forget run ./checkpatch.pl ?

--
Best regards,
Vladimir

Current Thread

[Next in Thread]

[PATCH v3 0/5] block: allow commit to unmap zero blocks, Vincent Vanlaer, 2024/09/01
- [PATCH v3 1/5] block: get type of block allocation in commit_run, Vincent Vanlaer, 2024/09/01
- [PATCH v3 4/5] block: allow commit to unmap zero blocks, Vincent Vanlaer, 2024/09/01
- [PATCH v3 2/5] block: move commit_run loop to separate function, Vincent Vanlaer, 2024/09/01
  - Re: [PATCH v3 2/5] block: move commit_run loop to separate function, Vladimir Sementsov-Ogievskiy, 2024/09/30
  - Re: [PATCH v3 2/5] block: move commit_run loop to separate function, Vladimir Sementsov-Ogievskiy <=
- [PATCH v3 3/5] block: refactor error handling of commit_iteration, Vincent Vanlaer, 2024/09/01
  - Re: [PATCH v3 3/5] block: refactor error handling of commit_iteration, Vladimir Sementsov-Ogievskiy, 2024/09/30
- [PATCH v3 5/5] block: add test non-active commit with zeroed data, Vincent Vanlaer, 2024/09/01