qemu-commits
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] b7022d: s390: Plug memory leak on s390_pci_ge

From: GitHub
Subject: [Qemu-commits] [qemu/qemu] b7022d: s390: Plug memory leak on s390_pci_generate_event(...
Date: Tue, 03 Feb 2015 06:30:13 -0800 
  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: b7022d9ac61311f92aef0994e2ab801b76d55f14
      
https://github.com/qemu/qemu/commit/b7022d9ac61311f92aef0994e2ab801b76d55f14
  Author: Markus Armbruster <address@hidden>
  Date:   2015-02-03 (Tue, 03 Feb 2015)

  Changed paths:
    M hw/s390x/s390-pci-bus.c

  Log Message:
  -----------
  s390: Plug memory leak on s390_pci_generate_event() error path

Signed-off-by: Markus Armbruster <address@hidden>
Signed-off-by: Cornelia Huck <address@hidden>


  Commit: c0eb33ab5428edf85a29a4f91f64d6802b6cefaa
      
https://github.com/qemu/qemu/commit/c0eb33ab5428edf85a29a4f91f64d6802b6cefaa
  Author: Frank Blaschka <address@hidden>
  Date:   2015-02-03 (Tue, 03 Feb 2015)

  Changed paths:
    M hw/s390x/s390-pci-inst.c

  Log Message:
  -----------
  s390x/pci: avoid sign extension in stpcifc

This patch avoids sign extension and fixes a data conversion
bug in stpcifc. Both issues where found by Coverity.

Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Frank Blaschka <address@hidden>
Signed-off-by: Cornelia Huck <address@hidden>


  Commit: 5b324bbafc4fe367bd9c5bfa6cff071081fb8b0e
      
https://github.com/qemu/qemu/commit/5b324bbafc4fe367bd9c5bfa6cff071081fb8b0e
  Author: Frank Blaschka <address@hidden>
  Date:   2015-02-03 (Tue, 03 Feb 2015)

  Changed paths:
    M hw/s390x/s390-pci-bus.c

  Log Message:
  -----------
  s390x/pci: check for invalid function handle

broken guest may provide 0 (invalid) function handle to zpci
instructions. Since we use function handle 0 to indicate an empty
slot in the PHB we have to add an additional check to spot this
kind of error.

Signed-off-by: Frank Blaschka <address@hidden>
Signed-off-by: Cornelia Huck <address@hidden>


  Commit: 4e99a0f7ae2a8392fd306c357148763ac4f820f9
      
https://github.com/qemu/qemu/commit/4e99a0f7ae2a8392fd306c357148763ac4f820f9
  Author: Yi Min Zhao <address@hidden>
  Date:   2015-02-03 (Tue, 03 Feb 2015)

  Changed paths:
    M hw/s390x/s390-pci-inst.c

  Log Message:
  -----------
  s390x/pci: fix dma notifications in rpcit instruction

The virtual I/O address range passed to rpcit instruction might not
map to consecutive physical guest pages. For this we have to translate
and create mapping notifications for each vioa page separately.

Signed-off-by: Yi Min Zhao <address@hidden>
Signed-off-by: Cornelia Huck <address@hidden>


  Commit: 20dd25bb67a51a4a57092b6381a6d4b0e64e2153
      
https://github.com/qemu/qemu/commit/20dd25bb67a51a4a57092b6381a6d4b0e64e2153
  Author: Thomas Huth <address@hidden>
  Date:   2015-02-03 (Tue, 03 Feb 2015)

  Changed paths:
    M target-s390x/kvm.c

  Log Message:
  -----------
  s390x/kvm: Fix diag-308 register decoding

Fix the decoding of the r1 register number in the diagnose 308 handler.

Signed-off-by: Thomas Huth <address@hidden>
Reviewed-by: Michael Mueller <address@hidden>
Signed-off-by: Cornelia Huck <address@hidden>


  Commit: 68540b1a1b505d9578699b03fe0b5da716a21dcc
      
https://github.com/qemu/qemu/commit/68540b1a1b505d9578699b03fe0b5da716a21dcc
  Author: Christian Borntraeger <address@hidden>
  Date:   2015-02-03 (Tue, 03 Feb 2015)

  Changed paths:
    M target-s390x/kvm.c

  Log Message:
  -----------
  s390x/kvm: unknown DIAGNOSE code should give a specification exception

As described in CP programming services an unimplemented DIAGNOSE
function should return a specification exception. Today we give the
guest an operation exception.
As both exception types are suppressing and Linux as a guest does not
care about the type of program check in its exception table handler
as long as both types have the same kind of error handling (nullifying,
terminating, suppressing etc.) this was unnoticed.

Reviewed-by: Thomas Huth <address@hidden>
Signed-off-by: Christian Borntraeger <address@hidden>
Signed-off-by: Cornelia Huck <address@hidden>


  Commit: 7691993c2b290dfedfb08a8eaa8cf7d5c6573fcb
      
https://github.com/qemu/qemu/commit/7691993c2b290dfedfb08a8eaa8cf7d5c6573fcb
  Author: Thomas Huth <address@hidden>
  Date:   2015-02-03 (Tue, 03 Feb 2015)

  Changed paths:
    M hw/s390x/ipl.c

  Log Message:
  -----------
  s390x/ipl: Improved code indentation in s390_ipl_init()

The indentation of the code in s390_ipl_init() can be simplified
a little bit by removing superfluous else-statements.

Suggested-by: Michael Mueller <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>
Acked-by: Cornelia Huck <address@hidden>
Signed-off-by: Cornelia Huck <address@hidden>


  Commit: f17a84300f3f3b5de45c8706a44d69d41d1727cb
      
https://github.com/qemu/qemu/commit/f17a84300f3f3b5de45c8706a44d69d41d1727cb
  Author: Christian Borntraeger <address@hidden>
  Date:   2015-02-03 (Tue, 03 Feb 2015)

  Changed paths:
    M pc-bios/s390-ccw/bootmap.c
    M pc-bios/s390-ccw/bootmap.h
    M pc-bios/s390-ccw/main.c
    M pc-bios/s390-ccw/s390-ccw.h
    M pc-bios/s390-ccw/virtio.c

  Log Message:
  -----------
  pc-bios/s390-ccw: fix sparse warnings

Fix some sparse warnings in the s390-ccw bios.

Signed-off-by: Christian Borntraeger <address@hidden>
Signed-off-by: Cornelia Huck <address@hidden>


  Commit: 553ce81c31e49d834b1bf635ab486695a4694333
      
https://github.com/qemu/qemu/commit/553ce81c31e49d834b1bf635ab486695a4694333
  Author: Cornelia Huck <address@hidden>
  Date:   2015-02-03 (Tue, 03 Feb 2015)

  Changed paths:
    M pc-bios/s390-ccw.img

  Log Message:
  -----------
  pc-bios/s390-ccw: update binary

Signed-off-by: Cornelia Huck <address@hidden>


  Commit: 007c99fd0fb4e0f0579872bb71f5de99b5943dc2
      
https://github.com/qemu/qemu/commit/007c99fd0fb4e0f0579872bb71f5de99b5943dc2
  Author: Peter Maydell <address@hidden>
  Date:   2015-02-03 (Tue, 03 Feb 2015)

  Changed paths:
    M hw/s390x/ipl.c
    M hw/s390x/s390-pci-bus.c
    M hw/s390x/s390-pci-inst.c
    M pc-bios/s390-ccw.img
    M pc-bios/s390-ccw/bootmap.c
    M pc-bios/s390-ccw/bootmap.h
    M pc-bios/s390-ccw/main.c
    M pc-bios/s390-ccw/s390-ccw.h
    M pc-bios/s390-ccw/virtio.c
    M target-s390x/kvm.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20150203' into staging

Some bugfixes and cleanups for s390x, both in the new pci code and
in old code.

# gpg: Signature made Tue 03 Feb 2015 13:01:04 GMT using RSA key ID C6F02FAF
# gpg: Good signature from "Cornelia Huck <address@hidden>"
# gpg:                 aka "Cornelia Huck <address@hidden>"

* remotes/cohuck/tags/s390x-20150203:
  pc-bios/s390-ccw: update binary
  pc-bios/s390-ccw: fix sparse warnings
  s390x/ipl: Improved code indentation in s390_ipl_init()
  s390x/kvm: unknown DIAGNOSE code should give a specification exception
  s390x/kvm: Fix diag-308 register decoding
  s390x/pci: fix dma notifications in rpcit instruction
  s390x/pci: check for invalid function handle
  s390x/pci: avoid sign extension in stpcifc
  s390: Plug memory leak on s390_pci_generate_event() error path

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/d5fbb4c9ed52...007c99fd0fb4
reply via email to
[Prev in Thread] Current Thread [Next in Thread]