[Qemu-commits] [qemu/qemu] 65255e: target/*helper: don't check retaddr b

qemu-commits

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 65255e: target/*helper: don't check retaddr b

From:	GitHub
Subject:	[Qemu-commits] [qemu/qemu] 65255e: target/*helper: don't check retaddr before calling...
Date:	Mon, 08 Jan 2018 09:39:35 -0800

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 65255e8efdd5fca602bcc4ff61a879939ff75f4f
      
https://github.com/qemu/qemu/commit/65255e8efdd5fca602bcc4ff61a879939ff75f4f
  Author: Alex Bennée <address@hidden>
  Date:   2017-12-27 (Wed, 27 Dec 2017)

  Changed paths:
    A scripts/coccinelle/cpu_restore_state.cocci
    M target/alpha/mem_helper.c
    M target/arm/op_helper.c
    M target/i386/svm_helper.c
    M target/lm32/op_helper.c
    M target/m68k/op_helper.c
    M target/microblaze/op_helper.c
    M target/moxie/helper.c
    M target/nios2/mmu.c
    M target/openrisc/mmu_helper.c
    M target/tricore/op_helper.c
    M target/unicore32/op_helper.c

  Log Message:
  -----------
  target/*helper: don't check retaddr before calling cpu_restore_state

cpu_restore_state officially supports being passed an address it can't
resolve the state for. As a result the checks in the helpers are
superfluous and can be removed. This makes the code consistent with
other users of cpu_restore_state.

Of course this does nothing to address what to do if cpu_restore_state
can't resolve the state but so far it seems this is handled elsewhere.

The change was made with included coccinelle script.

Signed-off-by: Alex Bennée <address@hidden>
[rth: Fixed up comment indentation.  Added second hunk to script to
combine cpu_restore_state and cpu_loop_exit.]
Signed-off-by: Richard Henderson <address@hidden>


  Commit: 1f5940e4642f4a2c64bcba724eaff3c28ae38c54
      
https://github.com/qemu/qemu/commit/1f5940e4642f4a2c64bcba724eaff3c28ae38c54
  Author: Richard Henderson <address@hidden>
  Date:   2017-12-27 (Wed, 27 Dec 2017)

  Changed paths:
    M target/moxie/helper.c

  Log Message:
  -----------
  target/moxie: Fix tlb_fill

We should not exit unless moxie_cpu_handle_mmu_fault has failed.

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: f764718d0cb30af9f1f8e1d6a33622cc05ca4155
      
https://github.com/qemu/qemu/commit/f764718d0cb30af9f1f8e1d6a33622cc05ca4155
  Author: Richard Henderson <address@hidden>
  Date:   2017-12-29 (Fri, 29 Dec 2017)

  Changed paths:
    M target/alpha/translate.c
    M target/arm/translate-a64.c
    M target/arm/translate.c
    M target/cris/translate.c
    M target/hppa/translate.c
    M target/i386/translate.c
    M target/m68k/translate.c
    M target/mips/translate.c
    M target/nios2/translate.c
    M target/ppc/translate.c
    M target/s390x/translate.c
    M target/sh4/translate.c
    M target/sparc/translate.c
    M target/tilegx/translate.c
    M target/unicore32/translate.c
    M tcg/tcg-op.h
    M tcg/tcg.c
    M tcg/tcg.h

  Log Message:
  -----------
  tcg: Remove TCGV_UNUSED* and TCGV_IS_UNUSED*

These are now trivial sets and tests against NULL.  Unwrap.

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: 15fa08f8451babc88d733bd411d4c94976f9d0f8
      
https://github.com/qemu/qemu/commit/15fa08f8451babc88d733bd411d4c94976f9d0f8
  Author: Richard Henderson <address@hidden>
  Date:   2017-12-29 (Fri, 29 Dec 2017)

  Changed paths:
    M include/exec/gen-icount.h
    M include/qemu/queue.h
    M target/arm/translate-a64.c
    M target/arm/translate.c
    M target/arm/translate.h
    M target/cris/translate.c
    M target/lm32/translate.c
    M target/microblaze/translate.c
    M tcg/optimize.c
    M tcg/tcg-op.c
    M tcg/tcg.c
    M tcg/tcg.h

  Log Message:
  -----------
  tcg: Dynamically allocate TCGOps

With no fixed array allocation, we can't overflow a buffer.
This will be important as optimizations related to host vectors
may expand the number of ops used.

Use QTAILQ to link the ops together.

Signed-off-by: Richard Henderson <address@hidden>


  Commit: cd9090aa9dbba30db8aec9a2fc103aaf1ab0f5a7
      
https://github.com/qemu/qemu/commit/cd9090aa9dbba30db8aec9a2fc103aaf1ab0f5a7
  Author: Richard Henderson <address@hidden>
  Date:   2017-12-29 (Fri, 29 Dec 2017)

  Changed paths:
    M tcg/optimize.c
    M tcg/tcg.c
    M tcg/tcg.h

  Log Message:
  -----------
  tcg: Generalize TCGOp parameters

We had two fields specific to INDEX_op_call.  Rename these and
add some macros so that the fields may be reused for other opcodes.

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: 923ed1750186591b04d7d61399f6d68b4e0608f2
      
https://github.com/qemu/qemu/commit/923ed1750186591b04d7d61399f6d68b4e0608f2
  Author: Richard Henderson <address@hidden>
  Date:   2017-12-29 (Fri, 29 Dec 2017)

  Changed paths:
    M tcg/tcg.h

  Log Message:
  -----------
  tcg: Add tcg_signed_cond

Complimenting the existing tcg_unsigned_cond.

Signed-off-by: Richard Henderson <address@hidden>


  Commit: 1df3caa946e08b387511dfba3a37d78910e51796
      
https://github.com/qemu/qemu/commit/1df3caa946e08b387511dfba3a37d78910e51796
  Author: Richard Henderson <address@hidden>
  Date:   2017-12-29 (Fri, 29 Dec 2017)

  Changed paths:
    M include/exec/helper-gen.h
    M include/exec/helper-head.h
    M include/exec/helper-proto.h
    M include/exec/helper-tcg.h
    M tcg/tcg.h
    M tcg/tci.c
    M tcg/tci/tcg-target.inc.c

  Log Message:
  -----------
  tcg: Allow 6 arguments to TCG helpers

We already handle this in the backends, and the lifetime datum
for the TCGOp is already large enough.

Signed-off-by: Richard Henderson <address@hidden>


  Commit: 4fad446bc955fcaa08a21388cf82268824bea10e
      
https://github.com/qemu/qemu/commit/4fad446bc955fcaa08a21388cf82268824bea10e
  Author: Paolo Bonzini <address@hidden>
  Date:   2017-12-29 (Fri, 29 Dec 2017)

  Changed paths:
    M accel/tcg/cpu-exec.c
    M accel/tcg/tcg-runtime.c

  Log Message:
  -----------
  tcg: add cs_base and flags to -d exec output

Signed-off-by: Paolo Bonzini <address@hidden>
Message-Id: <address@hidden>
[rth: Also change the Chain logging in helper_lookup_tb_ptr.]
Signed-off-by: Richard Henderson <address@hidden>


  Commit: 4124ea4f5bd367ca6412fb2dfe7ac4d80e1504d9
      
https://github.com/qemu/qemu/commit/4124ea4f5bd367ca6412fb2dfe7ac4d80e1504d9
  Author: Peter Maydell <address@hidden>
  Date:   2018-01-08 (Mon, 08 Jan 2018)

  Changed paths:
    M accel/tcg/cpu-exec.c
    M accel/tcg/tcg-runtime.c
    M include/exec/gen-icount.h
    M include/exec/helper-gen.h
    M include/exec/helper-head.h
    M include/exec/helper-proto.h
    M include/exec/helper-tcg.h
    M include/qemu/queue.h
    A scripts/coccinelle/cpu_restore_state.cocci
    M target/alpha/mem_helper.c
    M target/alpha/translate.c
    M target/arm/op_helper.c
    M target/arm/translate-a64.c
    M target/arm/translate.c
    M target/arm/translate.h
    M target/cris/translate.c
    M target/hppa/translate.c
    M target/i386/svm_helper.c
    M target/i386/translate.c
    M target/lm32/op_helper.c
    M target/lm32/translate.c
    M target/m68k/op_helper.c
    M target/m68k/translate.c
    M target/microblaze/op_helper.c
    M target/microblaze/translate.c
    M target/mips/translate.c
    M target/moxie/helper.c
    M target/nios2/mmu.c
    M target/nios2/translate.c
    M target/openrisc/mmu_helper.c
    M target/ppc/translate.c
    M target/s390x/translate.c
    M target/sh4/translate.c
    M target/sparc/translate.c
    M target/tilegx/translate.c
    M target/tricore/op_helper.c
    M target/unicore32/op_helper.c
    M target/unicore32/translate.c
    M tcg/optimize.c
    M tcg/tcg-op.c
    M tcg/tcg-op.h
    M tcg/tcg.c
    M tcg/tcg.h
    M tcg/tci.c
    M tcg/tci/tcg-target.inc.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20171229' into staging

Queued TCG patches

# gpg: Signature made Fri 29 Dec 2017 20:44:06 GMT
# gpg:                using RSA key 0x64DF38E8AF7E215F
# gpg: Good signature from "Richard Henderson <address@hidden>"
# Primary key fingerprint: 7A48 1E78 868B 4DB6 A85A  05C0 64DF 38E8 AF7E 215F

* remotes/rth/tags/pull-tcg-20171229:
  tcg: add cs_base and flags to -d exec output
  tcg: Allow 6 arguments to TCG helpers
  tcg: Add tcg_signed_cond
  tcg: Generalize TCGOp parameters
  tcg: Dynamically allocate TCGOps
  tcg: Remove TCGV_UNUSED* and TCGV_IS_UNUSED*
  target/moxie: Fix tlb_fill
  target/*helper: don't check retaddr before calling cpu_restore_state

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/799044b6a3a0...4124ea4f5bd3

[Prev in Thread]

Current Thread

[Next in Thread]

[Qemu-commits] [qemu/qemu] 65255e: target/*helper: don't check retaddr before calling..., GitHub <=

Prev by Date: [Qemu-commits] [qemu/qemu] 5fbfab: block: Formats don't need CONSISTENT_READ with NO_...
Next by Date: [Qemu-commits] [qemu/qemu] d2d085: configure: Fix incorrect string comparison operato...
Previous by thread: [Qemu-commits] [qemu/qemu] 5fbfab: block: Formats don't need CONSISTENT_READ with NO_...
Next by thread: [Qemu-commits] [qemu/qemu] d2d085: configure: Fix incorrect string comparison operato...
Index(es):
- Date
- Thread