[Qemu-commits] [qemu/qemu] c983ca: dump: fix note_name_equal()

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: c983ca845782bf91171b5ec4e59d122a21229745
      
https://github.com/qemu/qemu/commit/c983ca845782bf91171b5ec4e59d122a21229745
  Author: Marc-André Lureau <address@hidden>
  Date:   2018-01-02 (Tue, 02 Jan 2018)

  Changed paths:
    M dump.c

  Log Message:
  -----------
  dump: fix note_name_equal()

Use the function argument "name" instead of hardcoded
"VMCOREINFO". All callers use "VMCOREINFO" as argument, so this isn't
an exposed bug, thankfully.

Simplify a little bit the code while touching this.

Suggested-by: Andrew Jones <address@hidden>
Reported-by: Laszlo Ersek <address@hidden>
Signed-off-by: Marc-André Lureau <address@hidden>


  Commit: c3b1642b9b6b3ba4314d6be3be509d396372cfd5
      
https://github.com/qemu/qemu/commit/c3b1642b9b6b3ba4314d6be3be509d396372cfd5
  Author: Marc-André Lureau <address@hidden>
  Date:   2018-01-02 (Tue, 02 Jan 2018)

  Changed paths:
    M hw/misc/vmcoreinfo.c
    M scripts/dump-guest-memory.py

  Log Message:
  -----------
  dump-guest-memory.py: fix "You can't do that without a process to debug"

If the script is run with a core (no running process), it produces an
error:

(gdb)  dump-guest-memory /tmp/vmcore X86_64
guest RAM blocks:
target_start     target_end       host_addr        message count
---------------- ---------------- ---------------- ------- -----
0000000000000000 00000000000a0000 00007f7935800000 added       1
00000000000a0000 00000000000b0000 00007f7934200000 added       2
00000000000c0000 00000000000ca000 00007f79358c0000 added       3
00000000000ca000 00000000000cd000 00007f79358ca000 joined      3
00000000000cd000 00000000000e8000 00007f79358cd000 joined      3
00000000000e8000 00000000000f0000 00007f79358e8000 joined      3
00000000000f0000 0000000000100000 00007f79358f0000 joined      3
0000000000100000 0000000080000000 00007f7935900000 joined      3
00000000fd000000 00000000fe000000 00007f7934200000 added       4
00000000fffc0000 0000000100000000 00007f7935600000 added       5
Python Exception <class 'gdb.error'> You can't do that without a process to 
debug.:
Error occurred in Python command: You can't do that without a process
to debug.

Replace the object_resolve_path_type() function call with a local
volatile variable.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Laszlo Ersek <address@hidden>


  Commit: 4bd797af6f5bc9f7114030695716d199dceafa6e
      
https://github.com/qemu/qemu/commit/4bd797af6f5bc9f7114030695716d199dceafa6e
  Author: Peter Maydell <address@hidden>
  Date:   2018-01-08 (Mon, 08 Jan 2018)

  Changed paths:
    M dump.c
    M hw/misc/vmcoreinfo.c
    M scripts/dump-guest-memory.py

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/elmarco/tags/dump-pull-request' into 
staging

# gpg: Signature made Tue 02 Jan 2018 13:51:26 GMT
# gpg:                using RSA key 0xDAE8E10975969CE5
# gpg: Good signature from "Marc-André Lureau <address@hidden>"
# gpg:                 aka "Marc-André Lureau <address@hidden>"
# Primary key fingerprint: 87A9 BD93 3F87 C606 D276  F62D DAE8 E109 7596 9CE5

* remotes/elmarco/tags/dump-pull-request:
  dump-guest-memory.py: fix "You can't do that without a process to debug"
  dump: fix note_name_equal()

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/d2d0852271ca...4bd797af6f5b