[Qemu-commits] [qemu/qemu] b19a3e: machine: Move gpio code to hw/core/gp

qemu-commits
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] b19a3e: machine: Move gpio code to hw/core/gp

From:	Richard Henderson
Subject:	[Qemu-commits] [qemu/qemu] b19a3e: machine: Move gpio code to hw/core/gpio.c
Date:	Tue, 02 Nov 2021 02:59:18 -0700
  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: b19a3e2cd9c749f1925f1557a6409d1eefbd9b9c
      
https://github.com/qemu/qemu/commit/b19a3e2cd9c749f1925f1557a6409d1eefbd9b9c
  Author: Eduardo Habkost <ehabkost@redhat.com>
  Date:   2021-11-01 (Mon, 01 Nov 2021)

  Changed paths:
    A hw/core/gpio.c
    M hw/core/meson.build
    M hw/core/qdev.c

  Log Message:
  -----------
  machine: Move gpio code to hw/core/gpio.c

Only softmmu code uses gpio, so move gpio code from qdev.c to
gpio.c and compile it only on softmmu mode.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20190425200051.19906-2-ehabkost@redhat.com>
[PMD: Rebased]
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>


  Commit: d675b44ecca6e660256a59800dda96b242b74afe
      
https://github.com/qemu/qemu/commit/d675b44ecca6e660256a59800dda96b242b74afe
  Author: Philippe Mathieu-Daudé <philmd@redhat.com>
  Date:   2021-11-01 (Mon, 01 Nov 2021)

  Changed paths:
    M hw/core/meson.build

  Log Message:
  -----------
  hw/core: Restrict sysemu specific files

All these files don't make sense for tools and user emulation,
restrict them to system emulation.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Yanan Wang <wangyanan55@huawei.com>
Tested-by: Yanan Wang <wangyanan55@huawei.com>
Acked-by: Eduardo Habkost <ehabkost@redhat.com>
Message-Id: <20211028150521.1973821-2-philmd@redhat.com>


  Commit: f73fb063950b9da3a5869fe9ce396abf157c1d9f
      
https://github.com/qemu/qemu/commit/f73fb063950b9da3a5869fe9ce396abf157c1d9f
  Author: Philippe Mathieu-Daudé <philmd@redhat.com>
  Date:   2021-11-01 (Mon, 01 Nov 2021)

  Changed paths:
    M hw/core/meson.build
    M meson.build

  Log Message:
  -----------
  hw/core: Declare meson source set

As we want to be able to conditionally add files to the hw/core
file list, use a source set.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Yanan Wang <wangyanan55@huawei.com>
Tested-by: Yanan Wang <wangyanan55@huawei.com>
Acked-by: Eduardo Habkost <ehabkost@redhat.com>
Message-Id: <20211028150521.1973821-3-philmd@redhat.com>


  Commit: 81c7b381558541531fa119e16a58098d6febbf5f
      
https://github.com/qemu/qemu/commit/81c7b381558541531fa119e16a58098d6febbf5f
  Author: Philippe Mathieu-Daudé <philmd@redhat.com>
  Date:   2021-11-01 (Mon, 01 Nov 2021)

  Changed paths:
    M hw/core/meson.build
    A hw/core/qdev-hotplug.c
    M hw/core/qdev.c

  Log Message:
  -----------
  hw/core: Extract hotplug-related functions to qdev-hotplug.c

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Yanan Wang <wangyanan55@huawei.com>
Acked-by: Eduardo Habkost <ehabkost@redhat.com>
Message-Id: <20211028150521.1973821-4-philmd@redhat.com>


  Commit: 09112bef740853c9afd5318ecd0e93394648a3a6
      
https://github.com/qemu/qemu/commit/09112bef740853c9afd5318ecd0e93394648a3a6
  Author: Philippe Mathieu-Daudé <philmd@redhat.com>
  Date:   2021-11-01 (Mon, 01 Nov 2021)

  Changed paths:
    A hw/core/hotplug-stubs.c
    M hw/core/meson.build

  Log Message:
  -----------
  hw/core: Restrict hotplug to system emulation

Restrict hotplug to system emulation, add stubs for the other uses.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Yanan Wang <wangyanan55@huawei.com>
Acked-by: Eduardo Habkost <ehabkost@redhat.com>
Message-Id: <20211028150521.1973821-5-philmd@redhat.com>


  Commit: 86ce2d28fa09d15547b5cabdc264cadfb53a848c
      
https://github.com/qemu/qemu/commit/86ce2d28fa09d15547b5cabdc264cadfb53a848c
  Author: Yanan Wang <wangyanan55@huawei.com>
  Date:   2021-11-01 (Mon, 01 Nov 2021)

  Changed paths:
    M MAINTAINERS
    A hw/core/machine-smp.c
    M hw/core/machine.c
    M hw/core/meson.build
    M include/hw/boards.h

  Log Message:
  -----------
  hw/core/machine: Split out the smp parsing code

We are going to introduce an unit test for the parser smp_parse()
in hw/core/machine.c, but now machine.c is only built in softmmu.

In order to solve the build dependency on the smp parsing code and
avoid building unrelated stuff for the unit tests, move the tested
code from machine.c into a separate file, i.e., machine-smp.c and
build it in common field.

Signed-off-by: Yanan Wang <wangyanan55@huawei.com>
Reviewed-by: Andrew Jones <drjones@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20211026034659.22040-2-wangyanan55@huawei.com>
Acked-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>


  Commit: 9e8e393bb795ff6c6963c47376369e90b1d40467
      
https://github.com/qemu/qemu/commit/9e8e393bb795ff6c6963c47376369e90b1d40467
  Author: Yanan Wang <wangyanan55@huawei.com>
  Date:   2021-11-01 (Mon, 01 Nov 2021)

  Changed paths:
    M MAINTAINERS
    M tests/unit/meson.build
    A tests/unit/test-smp-parse.c

  Log Message:
  -----------
  tests/unit: Add an unit test for smp parsing

Now that we have a generic parser smp_parse(), let's add an unit
test for the code. All possible valid/invalid SMP configurations
that the user can specify are covered.

Signed-off-by: Yanan Wang <wangyanan55@huawei.com>
Reviewed-by: Andrew Jones <drjones@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20211026034659.22040-3-wangyanan55@huawei.com>
Acked-by: Eduardo Habkost <ehabkost@redhat.com>
Message-Id: <bfed7144-af86-7098-e7a6-731ff13c2cf7@huawei.com>
[PMD: Squashed format string fixup from Yanan Wang]
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>


  Commit: b5fdf4102fa3ecc35e7b84a398ccb3e00ca08944
      
https://github.com/qemu/qemu/commit/b5fdf4102fa3ecc35e7b84a398ccb3e00ca08944
  Author: Damien Hedde <damien.hedde@greensocs.com>
  Date:   2021-11-01 (Mon, 01 Nov 2021)

  Changed paths:
    M hw/core/machine.c
    M include/hw/boards.h

  Log Message:
  -----------
  machine: add device_type_is_dynamic_sysbus function

Right now the allowance check for adding a sysbus device using
-device cli option (or device_add qmp command) is done well after
the device has been created. It is done during the machine init done
notifier: machine_init_notify() in hw/core/machine.c

This new function will allow us to do the check at the right time and
issue an error if it fails.

Also make device_is_dynamic_sysbus() use the new function.

Signed-off-by: Damien Hedde <damien.hedde@greensocs.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Acked-by: Eduardo Habkost <ehabkost@redhat.com>
Message-Id: <20211029142258.484907-2-damien.hedde@greensocs.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>


  Commit: 312e1b1f3e8400cbba9fb59a57729768e72003ee
      
https://github.com/qemu/qemu/commit/312e1b1f3e8400cbba9fb59a57729768e72003ee
  Author: Damien Hedde <damien.hedde@greensocs.com>
  Date:   2021-11-01 (Mon, 01 Nov 2021)

  Changed paths:
    M softmmu/qdev-monitor.c

  Log Message:
  -----------
  qdev-monitor: Check sysbus device type before creating it

Add an early check to test if the requested sysbus device type
is allowed by the current machine before creating the device. This
impacts both -device cli option and device_add qmp command.

Before this patch, the check was done well after the device has
been created (in a machine init done notifier). We can now report
the error right away.

Signed-off-by: Damien Hedde <damien.hedde@greensocs.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Acked-by: Eduardo Habkost <ehabkost@redhat.com>
Message-Id: <20211029142258.484907-3-damien.hedde@greensocs.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>


  Commit: db78a6055994d20350a4c2131d67aeec303a7931
      
https://github.com/qemu/qemu/commit/db78a6055994d20350a4c2131d67aeec303a7931
  Author: Damien Hedde <damien.hedde@greensocs.com>
  Date:   2021-11-01 (Mon, 01 Nov 2021)

  Changed paths:
    M hw/core/machine.c
    M include/hw/boards.h

  Log Message:
  -----------
  machine: remove the done notifier for dynamic sysbus device type check

Now that we check sysbus device types during device creation, we
can remove the check in the machine init done notifier.
This was the only thing done by this notifier, so we remove the
whole sysbus_notifier structure of the MachineState.

Note: This notifier was checking all /peripheral and /peripheral-anon
sysbus devices. Now we only check those added by -device cli option or
device_add qmp command when handling the command/option. So if there
are some devices added in one of these containers manually (eg in
machine C code), these will not be checked anymore.
This use case does not seem to appear apart from
hw/xen/xen-legacy-backend.c (it uses qdev_set_id() and in this case,
not for a sysbus device, so it's ok).

Signed-off-by: Damien Hedde <damien.hedde@greensocs.com>
Acked-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Acked-by: Eduardo Habkost <ehabkost@redhat.com>
Message-Id: <20211029142258.484907-4-damien.hedde@greensocs.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>


  Commit: 8cb41fda78c7ebde0dd248c6afe1d336efb0de50
      
https://github.com/qemu/qemu/commit/8cb41fda78c7ebde0dd248c6afe1d336efb0de50
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2021-11-02 (Tue, 02 Nov 2021)

  Changed paths:
    M MAINTAINERS
    A hw/core/gpio.c
    A hw/core/hotplug-stubs.c
    A hw/core/machine-smp.c
    M hw/core/machine.c
    M hw/core/meson.build
    A hw/core/qdev-hotplug.c
    M hw/core/qdev.c
    M include/hw/boards.h
    M meson.build
    M softmmu/qdev-monitor.c
    M tests/unit/meson.build
    A tests/unit/test-smp-parse.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/philmd/tags/machine-20211101' into 
staging

Machine core patches

- Move GPIO code out of qdev.c
- Move hotplug code out of qdev.c
- Restrict various files to sysemu
- Move SMP code out of machine.c
- Add SMP parsing unit tests
- Move dynamic sysbus device check earlier

# gpg: Signature made Mon 01 Nov 2021 02:44:32 PM EDT
# gpg:                using RSA key FAABE75E12917221DCFD6BB2E3E32C2CDEADC0DE
# gpg: Good signature from "Philippe Mathieu-Daudé (F4BUG) <f4bug@amsat.org>" 
[full]

* remotes/philmd/tags/machine-20211101:
  machine: remove the done notifier for dynamic sysbus device type check
  qdev-monitor: Check sysbus device type before creating it
  machine: add device_type_is_dynamic_sysbus function
  tests/unit: Add an unit test for smp parsing
  hw/core/machine: Split out the smp parsing code
  hw/core: Restrict hotplug to system emulation
  hw/core: Extract hotplug-related functions to qdev-hotplug.c
  hw/core: Declare meson source set
  hw/core: Restrict sysemu specific files
  machine: Move gpio code to hw/core/gpio.c

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


Compare: https://github.com/qemu/qemu/compare/4b0bf11c5a4f...8cb41fda78c7
[Prev in Thread]
Current Thread
[Next in Thread]
[Qemu-commits] [qemu/qemu] b19a3e: machine: Move gpio code to hw/core/gpio.c, Richard Henderson <=
- [Qemu-commits] [qemu/qemu] b19a3e: machine: Move gpio code to hw/core/gpio.c, Richard Henderson, 2021/11/02
Prev by Date: [Qemu-commits] [qemu/qemu] 95a556: iotests/297: Move pylint config into pylintrc
Next by Date: [Qemu-commits] [qemu/qemu] b19a3e: machine: Move gpio code to hw/core/gpio.c
Previous by thread: [Qemu-commits] [qemu/qemu] 95a556: iotests/297: Move pylint config into pylintrc
Next by thread: [Qemu-commits] [qemu/qemu] b19a3e: machine: Move gpio code to hw/core/gpio.c
Index(es):
- Date
- Thread