[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] 90254e: scripts/qapi: minor delinting
|
From: |
Peter Maydell |
|
Subject: |
[Qemu-commits] [qemu/qemu] 90254e: scripts/qapi: minor delinting |
|
Date: |
Tue, 01 Mar 2022 05:26:00 -0800 |
Branch: refs/heads/master
Home: https://github.com/qemu/qemu
Commit: 90254ec46dbf9c844f913a23c88ee24fb969c49b
https://github.com/qemu/qemu/commit/90254ec46dbf9c844f913a23c88ee24fb969c49b
Author: John Snow <jsnow@redhat.com>
Date: 2022-02-28 (Mon, 28 Feb 2022)
Changed paths:
M scripts/qapi/commands.py
M scripts/qapi/pylintrc
M scripts/qapi/types.py
M scripts/qapi/visit.py
Log Message:
-----------
scripts/qapi: minor delinting
Get isort and pylint tools passing again.
Signed-off-by: John Snow <jsnow@redhat.com>
Message-Id: <20220211183650.2946895-1-jsnow@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
[Comment explaining good-names-rgxs tweaked]
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Commit: bbe0342b2a9b3232282dbaa2080763654e51870b
https://github.com/qemu/qemu/commit/bbe0342b2a9b3232282dbaa2080763654e51870b
Author: Markus Armbruster <armbru@redhat.com>
Date: 2022-02-28 (Mon, 28 Feb 2022)
Changed paths:
M util/keyval.c
Log Message:
-----------
keyval: Fix grammar comment to cover downstream prefix
According to the grammar, a key __com.redhat_foo would be parsed as
two key fragments __com and redhat_foo. It's actually parsed as a
single fragment. Fix the grammar.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20220218145551.892787-2-armbru@redhat.com>
Commit: 429d79e6be65b26d707f966aed03455badda8ef7
https://github.com/qemu/qemu/commit/429d79e6be65b26d707f966aed03455badda8ef7
Author: Markus Armbruster <armbru@redhat.com>
Date: 2022-02-28 (Mon, 28 Feb 2022)
Changed paths:
M qapi/qapi-util.c
Log Message:
-----------
qapi: Fix stale reference to scripts/qapi.py in a comment
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20220218145551.892787-3-armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Commit: b1ca53224a9161292a2801f0f41377f3ee83c609
https://github.com/qemu/qemu/commit/b1ca53224a9161292a2801f0f41377f3ee83c609
Author: Fabian Holler <fabian.holler@simplesurance.de>
Date: 2022-02-28 (Mon, 28 Feb 2022)
Changed paths:
M qapi/migration.json
Log Message:
-----------
qapi/migration: Fix examples document wrong field name for arguments
The examples for the snapshot-* and calc-dirty-rate commands document
that arguments for the commands are passed in a 'data' field.
This is wrong, passing them in a "data" field results in
the error:
{"error": {"class": "GenericError", "desc": "QMP input member 'data'
is unexpected"}}
Arguments are expected to be passed in an field called "arguments".
Replace "data" with "arguments" in the snapshot-* and calc-dirty-rate
command examples.
Signed-off-by: Fabian Holler <fabian.holler@simplesurance.de>
Message-Id: <20220222170116.63105-1-fabian.holler@simplesurance.de>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Commit: 1f216b8ca961e95c221a5e9c84d264ab0f3d7667
https://github.com/qemu/qemu/commit/1f216b8ca961e95c221a5e9c84d264ab0f3d7667
Author: Peter Maydell <peter.maydell@linaro.org>
Date: 2022-02-28 (Mon, 28 Feb 2022)
Changed paths:
M hw/ppc/spapr_rtc.c
M hw/rtc/mc146818rtc.c
M hw/rtc/pl031.c
M qapi/misc-target.json
M qapi/misc.json
Log Message:
-----------
qapi: Move RTC_CHANGE back out of target schema
This commit effectively reverts commit 183e4281a30962, which moved
the RTC_CHANGE event to the target schema. That change was an
attempt to make the event target-specific to improve introspection,
but the event isn't really target-specific: it's machine or device
specific. Putting RTC_CHANGE in the target schema with an ifdef list
reduces maintainability (by adding an if: list with a long list of
targets that needs to be manually updated as architectures are added
or removed or as new devices gain the RTC_CHANGE functionality) and
increases compile time (by preventing RTC devices which emit the
event from being "compile once" rather than "compile once per
target", because qapi-events-misc-target.h uses TARGET_* ifdefs,
which are poisoned in "compile once" files.)
Move RTC_CHANGE back to misc.json.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Greg Kurz <groug@kaod.org>
Message-Id: <20220221192123.749970-2-peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Commit: e67e3a48c0b1aa816a192e2c506a6f90dcfc9530
https://github.com/qemu/qemu/commit/e67e3a48c0b1aa816a192e2c506a6f90dcfc9530
Author: Peter Maydell <peter.maydell@linaro.org>
Date: 2022-02-28 (Mon, 28 Feb 2022)
Changed paths:
M qapi/misc.json
Log Message:
-----------
qapi: Document some missing details of RTC_CHANGE event
The RTC_CHANGE event's documentation is missing some details:
* the offset argument is in units of seconds
* it isn't guaranteed that the RTC will implement the event
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20220221192123.749970-3-peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Commit: 03397528d96ff5d631fd2fa40b753548e53b5149
https://github.com/qemu/qemu/commit/03397528d96ff5d631fd2fa40b753548e53b5149
Author: Peter Maydell <peter.maydell@linaro.org>
Date: 2022-02-28 (Mon, 28 Feb 2022)
Changed paths:
M hw/rtc/meson.build
Log Message:
-----------
hw/rtc: Compile pl031 once-only
Now that the RTC_CHANGE event is no longer target-specific,
we can move the pl031 back to a compile-once source file
rather than a compile-per-target one.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20220221192123.749970-4-peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Commit: 2beb1e5f9acb443d90fe4d366463f89d32d83bc8
https://github.com/qemu/qemu/commit/2beb1e5f9acb443d90fe4d366463f89d32d83bc8
Author: Markus Armbruster <armbru@redhat.com>
Date: 2022-02-28 (Mon, 28 Feb 2022)
Changed paths:
M hw/ppc/spapr_rtc.c
M hw/rtc/mc146818rtc.c
M hw/rtc/pl031.c
M qapi/misc.json
Log Message:
-----------
rtc: Have event RTC_CHANGE identify the RTC by QOM path
Event RTC_CHANGE is "emitted when the guest changes the RTC time" (and
the RTC supports the event). What if there's more than one RTC?
Which one changed? New @qom-path identifies it.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <87a6ejnm80.fsf@pond.sub.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Commit: 1428502c8c0c0cfbb04212558144fef970042cf3
https://github.com/qemu/qemu/commit/1428502c8c0c0cfbb04212558144fef970042cf3
Author: Markus Armbruster <armbru@redhat.com>
Date: 2022-02-28 (Mon, 28 Feb 2022)
Changed paths:
M qapi/compat.json
Log Message:
-----------
qapi: Belatedly adjust limitations documentation
Commit 57df0dff1a "qapi: Extend -compat to set policy for unstable
interfaces" (v6.2.0) took care of covering experimental features, but
neglected to adjust a comment suggesting to cover it. Adjust it now.
Fixes: 57df0dff1a1f4c846aa74a082bfd595a8a990015
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20220225084538.218876-1-armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Commit: 648c15e4ec3470513624c4b54f09fd15adb12258
https://github.com/qemu/qemu/commit/648c15e4ec3470513624c4b54f09fd15adb12258
Author: Peter Maydell <peter.maydell@linaro.org>
Date: 2022-03-01 (Tue, 01 Mar 2022)
Changed paths:
M hw/ppc/spapr_rtc.c
M hw/rtc/mc146818rtc.c
M hw/rtc/meson.build
M hw/rtc/pl031.c
M qapi/compat.json
M qapi/migration.json
M qapi/misc-target.json
M qapi/misc.json
M qapi/qapi-util.c
M scripts/qapi/commands.py
M scripts/qapi/pylintrc
M scripts/qapi/types.py
M scripts/qapi/visit.py
M util/keyval.c
Log Message:
-----------
Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2022-02-28' into
staging
QAPI patches patches for 2022-02-28
# gpg: Signature made Mon 28 Feb 2022 10:40:22 GMT
# gpg: using RSA key 354BC8B3D7EB2A6B68674E5F3870B400EB918653
# gpg: issuer "armbru@redhat.com"
# gpg: Good signature from "Markus Armbruster <armbru@redhat.com>" [full]
# gpg: aka "Markus Armbruster <armbru@pond.sub.org>" [full]
# Primary key fingerprint: 354B C8B3 D7EB 2A6B 6867 4E5F 3870 B400 EB91 8653
* remotes/armbru/tags/pull-qapi-2022-02-28:
qapi: Belatedly adjust limitations documentation
rtc: Have event RTC_CHANGE identify the RTC by QOM path
hw/rtc: Compile pl031 once-only
qapi: Document some missing details of RTC_CHANGE event
qapi: Move RTC_CHANGE back out of target schema
qapi/migration: Fix examples document wrong field name for arguments
qapi: Fix stale reference to scripts/qapi.py in a comment
keyval: Fix grammar comment to cover downstream prefix
scripts/qapi: minor delinting
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Compare: https://github.com/qemu/qemu/compare/a8d39f5b5ae8...648c15e4ec34