[Qemu-commits] [qemu/qemu] 1fb877: target/nios2: Remove mmu_read_debug

[Peter Maydell]

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: 1fb877a467014ec5a31cac63b067a38c13c684f0
      
https://github.com/qemu/qemu/commit/1fb877a467014ec5a31cac63b067a38c13c684f0
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2022-03-03 (Thu, 03 Mar 2022)

  Changed paths:
    M target/nios2/helper.h
    M target/nios2/mmu.c
    M target/nios2/mmu.h
    M target/nios2/op_helper.c
    M target/nios2/translate.c

  Log Message:
  -----------
  target/nios2: Remove mmu_read_debug

This functionality can be had via plugins, if desired.
In the meantime, it is unused code.

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


  Commit: 6f83e277eb9fa56c89fb25903834a21725655920
      
https://github.com/qemu/qemu/commit/6f83e277eb9fa56c89fb25903834a21725655920
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2022-03-03 (Thu, 03 Mar 2022)

  Changed paths:
    M meson.build
    M target/nios2/mmu.c
    A target/nios2/trace-events

  Log Message:
  -----------
  target/nios2: Replace MMU_LOG with tracepoints

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


  Commit: d8e609e9bb5a6b70ae2ba45fd14efffada013752
      
https://github.com/qemu/qemu/commit/d8e609e9bb5a6b70ae2ba45fd14efffada013752
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2022-03-03 (Thu, 03 Mar 2022)

  Changed paths:
    M target/nios2/meson.build
    M target/nios2/mmu.c

  Log Message:
  -----------
  target/nios2: Only build mmu.c for system mode

We can thus remove an ifdef covering the entire file.

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


  Commit: 0b6e8f5b234181198f4864f201bef13842987525
      
https://github.com/qemu/qemu/commit/0b6e8f5b234181198f4864f201bef13842987525
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2022-03-03 (Thu, 03 Mar 2022)

  Changed paths:
    M target/nios2/translate.c

  Log Message:
  -----------
  target/nios2: Hoist R_ZERO check in rdctl

This will avoid having to replicate the check to additional cases.

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


  Commit: 304c05df7c3e383133a70e20d7b5121d75ae4190
      
https://github.com/qemu/qemu/commit/304c05df7c3e383133a70e20d7b5121d75ae4190
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2022-03-03 (Thu, 03 Mar 2022)

  Changed paths:
    M target/nios2/helper.h
    M target/nios2/mmu.c
    M target/nios2/op_helper.c
    M target/nios2/translate.c

  Log Message:
  -----------
  target/nios2: Split mmu_write

Create three separate functions for the three separate registers.
Avoid extra dispatch through op_helper.c.
Dispatch to the correct function in translation.
Clean up the ifdefs in wrctl.

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


  Commit: 8d8d73b55144e0d8d3c15a83a8fd8f3de78c460d
      
https://github.com/qemu/qemu/commit/8d8d73b55144e0d8d3c15a83a8fd8f3de78c460d
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2022-03-03 (Thu, 03 Mar 2022)

  Changed paths:
    M target/nios2/translate.c

  Log Message:
  -----------
  target/nios2: Special case ipending in rdctl and wrctl

It was never correct to be able to write to ipending.
Until the rest of the irq code is tidied, the read of
ipending will generate an "unnecessary" mask.

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


  Commit: b72c9d5951f1dfa047f545408dd9e35597e6b9d3
      
https://github.com/qemu/qemu/commit/b72c9d5951f1dfa047f545408dd9e35597e6b9d3
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2022-03-03 (Thu, 03 Mar 2022)

  Changed paths:
    M target/nios2/cpu.c
    M target/nios2/cpu.h
    M target/nios2/helper.h
    M target/nios2/op_helper.c
    M target/nios2/translate.c

  Log Message:
  -----------
  target/nios2: Rewrite interrupt handling

Previously, we would avoid setting CPU_INTERRUPT_HARD when interrupts
are disabled at a particular point in time, instead queuing the value
into cpu->irq_pending.  This is more complicated than required.

Instead, set CPU_INTERRUPT_HARD any time there is a pending interrupt,
and exclusively check for interrupts disabled in nios2_cpu_exec_interrupt.

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


  Commit: 4c1d764d586f2dd126285a11cddb4ec683d033fa
      
https://github.com/qemu/qemu/commit/4c1d764d586f2dd126285a11cddb4ec683d033fa
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2022-03-04 (Fri, 04 Mar 2022)

  Changed paths:
    M meson.build
    M target/nios2/cpu.c
    M target/nios2/cpu.h
    M target/nios2/helper.h
    M target/nios2/meson.build
    M target/nios2/mmu.c
    M target/nios2/mmu.h
    M target/nios2/op_helper.c
    A target/nios2/trace-events
    M target/nios2/translate.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/rth-gitlab/tags/pull-nios-20220303' 
into staging

Rewrite nios2 interrupt handling

# gpg: Signature made Thu 03 Mar 2022 19:52:33 GMT
# gpg:                using RSA key 7A481E78868B4DB6A85A05C064DF38E8AF7E215F
# gpg:                issuer "richard.henderson@linaro.org"
# gpg: Good signature from "Richard Henderson <richard.henderson@linaro.org>" 
[full]
# Primary key fingerprint: 7A48 1E78 868B 4DB6 A85A  05C0 64DF 38E8 AF7E 215F

* remotes/rth-gitlab/tags/pull-nios-20220303:
  target/nios2: Rewrite interrupt handling
  target/nios2: Special case ipending in rdctl and wrctl
  target/nios2: Split mmu_write
  target/nios2: Hoist R_ZERO check in rdctl
  target/nios2: Only build mmu.c for system mode
  target/nios2: Replace MMU_LOG with tracepoints
  target/nios2: Remove mmu_read_debug

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/5959ef7d431f...4c1d764d586f