[Qemu-commits] [qemu/qemu] bda106: migration: Disable postcopy + multifd migration

[Richard Henderson]

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: bda1067daa2e03a0f1f201c75e358c48c1b918ed
      
https://github.com/qemu/qemu/commit/bda1067daa2e03a0f1f201c75e358c48c1b918ed
  Author: Leonardo Bras <leobras@redhat.com>
  Date:   2023-04-26 (Wed, 26 Apr 2023)

  Changed paths:
    M migration/options.c

  Log Message:
  -----------
  migration: Disable postcopy + multifd migration

Since the introduction of multifd, it's possible to perform a multifd
migration and finish it using postcopy.

A bug introduced by yank (fixed on cfc3bcf373) was previously preventing
a successful use of this migration scenario, and now thing should be
working on most scenarios.

But since there is not enough testing/support nor any reported users for
this scenario, we should disable this combination before it may cause any
problems for users.

Suggested-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Leonardo Bras <leobras@redhat.com>
Acked-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: 437fd04e73fc4934f2550cefde4610aa7043f1ce
      
https://github.com/qemu/qemu/commit/437fd04e73fc4934f2550cefde4610aa7043f1ce
  Author: Juan Quintela <quintela@redhat.com>
  Date:   2023-04-26 (Wed, 26 Apr 2023)

  Changed paths:
    M MAINTAINERS

  Log Message:
  -----------
  MAINTAINERS: Add Leonardo and Peter as reviewers

Now that David has stepped down with Migration maintainership,
Leonardo and Peter has volunteer to review the migration patches.
This way they got CC'd on every migration patch.

Signed-off-by: Juan Quintela <quintela@redhat.com>
Acked-by: Peter Xu <peterx@redhat.com>
Acked-by: Leonardo Bras <leobras@redhat.com>


  Commit: 33ea96956c4e978034a78991abf9f91001610d07
      
https://github.com/qemu/qemu/commit/33ea96956c4e978034a78991abf9f91001610d07
  Author: Juan Quintela <quintela@redhat.com>
  Date:   2023-04-26 (Wed, 26 Apr 2023)

  Changed paths:
    M migration/migration.c
    M migration/migration.h
    M migration/options.c
    M migration/options.h
    M migration/tls.c

  Log Message:
  -----------
  migration: Move migrate_use_tls() to options.c

Once there, rename it to migrate_tls() and make it return bool for
consistency.

Signed-off-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>

---

Fix typos found by fabiano


  Commit: bf3e8f9358ee7ba0f5b3bd0f7d8a131f51d0ebc9
      
https://github.com/qemu/qemu/commit/bf3e8f9358ee7ba0f5b3bd0f7d8a131f51d0ebc9
  Author: Juan Quintela <quintela@redhat.com>
  Date:   2023-04-26 (Wed, 26 Apr 2023)

  Changed paths:
    M migration/migration.c
    M migration/options.c
    M migration/options.h

  Log Message:
  -----------
  migration: Move qmp_migrate_set_parameters() to options.c

Signed-off-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>


  Commit: 660159117f455630010b4bdd35836198c1e41f0b
      
https://github.com/qemu/qemu/commit/660159117f455630010b4bdd35836198c1e41f0b
  Author: Peter Xu <peterx@redhat.com>
  Date:   2023-04-26 (Wed, 26 Apr 2023)

  Changed paths:
    M migration/options.c
    M migration/postcopy-ram.c
    M migration/postcopy-ram.h
    M migration/savevm.c

  Log Message:
  -----------
  migration: Allow postcopy_ram_supported_by_host() to report err

Instead of print it to STDERR, bring the error upwards so that it can be
reported via QMP responses.

E.g.:

{ "execute": "migrate-set-capabilities" ,
  "arguments": { "capabilities":
  [ { "capability": "postcopy-ram", "state": true } ] } }

{ "error":
  { "class": "GenericError",
    "desc": "Postcopy is not supported: Host backend files need to be TMPFS
    or HUGETLBFS only" } }

Signed-off-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: 8c869dd4abcde91534a3ac2eb6488d56362aec56
      
https://github.com/qemu/qemu/commit/8c869dd4abcde91534a3ac2eb6488d56362aec56
  Author: Peter Xu <peterx@redhat.com>
  Date:   2023-04-26 (Wed, 26 Apr 2023)

  Changed paths:
    M migration/savevm.c

  Log Message:
  -----------
  migration/vmstate-dump: Dump array size too as "num"

For VMS_ARRAY typed vmsd fields, also dump the number of entries in the
array in -vmstate-dump.

Without such information, vmstate static checker can report false negatives
of incompatible vmsd on VMS_ARRAY typed fields, when the src/dst do not
have the same type of array defined.  It's because in the checker we only
check against size of fields within a VMSD field.

One example: e1000e used to have a field defined as a boolean array with 5
entries, then removed it and replaced it with UNUSED (in 31e3f318c8b535):

-        VMSTATE_BOOL_ARRAY(core.eitr_intr_pending, E1000EState,
-                           E1000E_MSIX_VEC_NUM),
+        VMSTATE_UNUSED(E1000E_MSIX_VEC_NUM),

It's a legal replacement but vmstate static checker is not happy with it,
because it checks only against the "size" field between the two
fields (here one is BOOL_ARRAY, the other is UNUSED):

For BOOL_ARRAY:

      {
        "field": "core.eitr_intr_pending",
        "version_id": 0,
        "field_exists": false,
        "size": 1
      },

For UNUSED:

      {
        "field": "unused",
        "version_id": 0,
        "field_exists": false,
        "size": 5
      },

It's not the script to blame because there's just not enough information
dumped to show the total size of the entry for an array.  Add it.

Note that this will not break old vmstate checker because the field will
just be ignored.

Signed-off-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: 7b5cd8ff519e9fe3df6cda65428a6f1aa28a6ced
      
https://github.com/qemu/qemu/commit/7b5cd8ff519e9fe3df6cda65428a6f1aa28a6ced
  Author: Peter Xu <peterx@redhat.com>
  Date:   2023-04-26 (Wed, 26 Apr 2023)

  Changed paths:
    M scripts/vmstate-static-checker.py

  Log Message:
  -----------
  vmstate-static-checker: Recognize "num" field

Recognize this field for VMS_ARRAY typed vmsd fields, then we can do proper
size matching with previous patch.

Note that this is compatible with old -dump-vmstate output, because when
"num" is not there we'll still use the old "size" only.

Signed-off-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: 0ccb483dc7080769e61c2cfac5fd389486ad65f5
      
https://github.com/qemu/qemu/commit/0ccb483dc7080769e61c2cfac5fd389486ad65f5
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2023-04-27 (Thu, 27 Apr 2023)

  Changed paths:
    M MAINTAINERS
    M migration/migration.c
    M migration/migration.h
    M migration/options.c
    M migration/options.h
    M migration/postcopy-ram.c
    M migration/postcopy-ram.h
    M migration/savevm.c
    M migration/tls.c
    M scripts/vmstate-static-checker.py

  Log Message:
  -----------
  Merge tag 'migration-20230426-pull-request' of 
https://gitlab.com/juan.quintela/qemu into staging

Migration Pull request

Hi

This PULL request is on top of migration-20230424 already queued by
Richard.

It contains:
- MAINTAINERS: make peter and leo reviewers for migration (juan)
- Disable postcopy + multifd together. It needs at least to call
  send_sync before it will work. (juan)
- Improve postcopy error messages (peter)
- vmstate checker: Compare sizes of arrays correctly (peter)
- Move more capability functions to options.c (juan)

Please, apply.

Subject: [PULL 00/30] Migration 20230424 patches
Based-on: <20230424132730.70752-1-quintela@redhat.com>

# -----BEGIN PGP SIGNATURE-----
#
# iQIzBAABCAAdFiEEGJn/jt6/WMzuA0uC9IfvGFhy1yMFAmRJaVEACgkQ9IfvGFhy
# 1yMz8RAA1UBh1sj4xN2wbSehuLAduDYrkY4E5X0IP1y+8A8QAwdnXacdfFK6ZZTc
# N2edUB3kb9xlHJpL9ae0Pg0c0KBmFrHTrnOAs8s1ytQxRjIIZf6ezxy3K6VLMKHN
# QpSv2T7h3AEjJw/2OKazX2Tn3f/Ce0PTrnaoR4D7cYhe2FwJZC6nH/+AkPsoa+uE
# u51vC4ZXoyTjScck31ZWZylRwJtyv4Zrd8IiMneeP9TUfjtnI4N2+wi7Pmh1weHe
# Y2Pwq0Zrq7b4FF2FGTkjg6uXp3VR7wB8gmI3RY/jfBUKv1fUM5FBuevafq3Uzf+D
# 0eD22gqsRcY+1lGa5MQoj7MCCLHsUWbKeXkh5Jdc+ZMKU3E+LYq2jxxQDv2pUkgG
# X7Kq5QyAazAXfgXLzbs+oF1A8yH1ELPAO7tDjV2PTM1vbO4QmKP/seGVslM08RdL
# fiYET4oiNOi7I+R6DAkftSB0z26ii8pTvWLRZvn3t3g4VSWxzSnoYIoEwmXPBX7j
# UNpLxaEYX0TFhtazxCjR5Fj3pHR8zTlpMA6hMKW74roDP8nyGRWS3eoJv+syDvNZ
# Qrno71xVgQ96kRsC8YZkfibRReyPaH9vEW9sYRAmU21zD3e3kN2mjRK0ZI5lU3xG
# y13itgyrgEZqfT75GS6D/crpTp4MiuUmutIIXwQ5NJ4qGlSLVps=
# =+8ZH
# -----END PGP SIGNATURE-----
# gpg: Signature made Wed 26 Apr 2023 07:11:29 PM BST
# gpg:                using RSA key 1899FF8EDEBF58CCEE034B82F487EF185872D723
# gpg: Good signature from "Juan Quintela <quintela@redhat.com>" [undefined]
# gpg:                 aka "Juan Quintela <quintela@trasno.org>" [undefined]
# gpg: WARNING: This key is not certified with a trusted signature!
# gpg:          There is no indication that the signature belongs to the owner.
# Primary key fingerprint: 1899 FF8E DEBF 58CC EE03  4B82 F487 EF18 5872 D723

* tag 'migration-20230426-pull-request' of 
https://gitlab.com/juan.quintela/qemu:
  vmstate-static-checker: Recognize "num" field
  migration/vmstate-dump: Dump array size too as "num"
  migration: Allow postcopy_ram_supported_by_host() to report err
  migration: Move qmp_migrate_set_parameters() to options.c
  migration: Move migrate_use_tls() to options.c
  MAINTAINERS: Add Leonardo and Peter as reviewers
  migration: Disable postcopy + multifd migration

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


Compare: https://github.com/qemu/qemu/compare/c3f9aa8e488d...0ccb483dc708