[Qemu-commits] [qemu/qemu] 5a954e: qga/linux: add usb support to guest-get-fsinfo

[Richard Henderson]

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: 5a954e0221376e568b1419b6e120af0be83d78bb
      
https://github.com/qemu/qemu/commit/5a954e0221376e568b1419b6e120af0be83d78bb
  Author: Kfir Manor <kfir@daynix.com>
  Date:   2023-05-04 (Thu, 04 May 2023)

  Changed paths:
    M qga/commands-posix.c

  Log Message:
  -----------
  qga/linux: add usb support to guest-get-fsinfo

Signed-off-by: Kfir Manor <kfir@daynix.com>
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>


  Commit: 9c5ccc52abe3977be53e42af84a6e590b3e1db19
      
https://github.com/qemu/qemu/commit/9c5ccc52abe3977be53e42af84a6e590b3e1db19
  Author: Daniel Xu <dxu@dxuuu.xyz>
  Date:   2023-05-04 (Thu, 04 May 2023)

  Changed paths:
    M qga/commands.c
    M qga/qapi-schema.json

  Log Message:
  -----------
  qga: Refactor guest-exec capture-output to take enum

Previously capture-output was an optional boolean flag that either
captured all output or captured none. While this is OK in most cases, it
lacks flexibility for more advanced capture cases, such as wanting to
only capture stdout.

This commits refactors guest-exec qapi to take an enum for capture mode
instead while preserving backwards compatibility.

Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Daniel Xu <dxu@dxuuu.xyz>
Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>


  Commit: 810f677ab86e649d449233b435197552024b016d
      
https://github.com/qemu/qemu/commit/810f677ab86e649d449233b435197552024b016d
  Author: Daniel Xu <dxu@dxuuu.xyz>
  Date:   2023-05-04 (Thu, 04 May 2023)

  Changed paths:
    M qga/commands.c
    M qga/qapi-schema.json

  Log Message:
  -----------
  qga: Add `merged` variant to GuestExecCaptureOutputMode

Currently, any captured output (via `capture-output`) is segregated into
separate GuestExecStatus fields (`out-data` and `err-data`). This means
that downstream consumers have no way to reassemble the captured data
back into the original stream.

This is relevant for chatty and semi-interactive (ie. read only) CLI
tools.  Such tools may deliberately interleave stdout and stderr for
visual effect. If segregated, the output becomes harder to visually
understand.

This commit adds a new enum variant to the GuestExecCaptureOutputMode
qapi to merge the output streams such that consumers can have a pristine
view of the original command output.

Signed-off-by: Daniel Xu <dxu@dxuuu.xyz>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>


  Commit: c7d74f272450b032cd5d1317ee017b4ffe65ee89
      
https://github.com/qemu/qemu/commit/c7d74f272450b032cd5d1317ee017b4ffe65ee89
  Author: Daniel Xu <dxu@dxuuu.xyz>
  Date:   2023-05-04 (Thu, 04 May 2023)

  Changed paths:
    M tests/unit/test-qga.c

  Log Message:
  -----------
  qga: test: Add tests for `merged` flag

This commit adds a test to ensure `merged` functions as expected.
We also add a negative test to ensure we haven't regressed previous
functionality.

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Daniel Xu <dxu@dxuuu.xyz>
Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>


  Commit: 8cc28cb16e696580ffa29cd5fee0d371303c805b
      
https://github.com/qemu/qemu/commit/8cc28cb16e696580ffa29cd5fee0d371303c805b
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2023-05-04 (Thu, 04 May 2023)

  Changed paths:
    M qga/commands-win32.c

  Log Message:
  -----------
  qga/commands-win32.c: Drop the check for _WIN32_WINNT >= 0x0601

All current versions of glib require _WIN32_WINNT set to 0x0601
or higher already, and we also use this value as a minimum in our
osdep.h header file, so there is no way to still compile this code
with an older version of the Windows ABI. Thus we can drop this
check now.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>


  Commit: 86dcb6ab9b603450eb6d896cdc95286de2c7d561
      
https://github.com/qemu/qemu/commit/86dcb6ab9b603450eb6d896cdc95286de2c7d561
  Author: Mark Somerville <mark@qpok.net>
  Date:   2023-05-04 (Thu, 04 May 2023)

  Changed paths:
    M qga/commands-posix.c

  Log Message:
  -----------
  qga: Fix suspend on Linux guests without systemd

Allow the Linux guest agent to attempt each of the suspend methods
(systemctl, pm-* and writing to /sys) in turn.

Prior to this guests without systemd failed to suspend due to
`guest_suspend` returning early regardless of the return value of
`systemd_supports_mode`.

Signed-off-by: Mark Somerville <mark@qpok.net>
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>


  Commit: f6b761bdbd8ba63cee7428d52fb6b46e4224ddab
      
https://github.com/qemu/qemu/commit/f6b761bdbd8ba63cee7428d52fb6b46e4224ddab
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2023-05-04 (Thu, 04 May 2023)

  Changed paths:
    M qga/commands-posix.c
    M qga/commands-win32.c
    M qga/commands.c
    M qga/qapi-schema.json
    M tests/unit/test-qga.c

  Log Message:
  -----------
  Merge tag 'qga-pull-2023-05-04' of https://github.com/kostyanf14/qemu into 
staging

qga-pull-2023-05-04

# -----BEGIN PGP SIGNATURE-----
#
# iQIzBAABCgAdFiEEwsLBCepDxjwUI+uE711egWG6hOcFAmRTf4EACgkQ711egWG6
# hOdczhAAoMkw/bWZtpiEmeLIcliNVuF3gzouHRp2sBFeHCUtaE2jzmriuy4QqH81
# G+kgqdEogqv7G5Qq2LXNcbSl76eZnKbumtlj+N4XIDoukPWUmItIjuM9NYM0U84Y
# DAsj6o8Kw1W+GMBmk6AuLFNYMwv41GS6RyvH/daeYEGmFf0jYIARpeldTUxkxY86
# dfEylVPBfLjkctKfgl0h5GzRkYjmxyeisyigx4Wk8sVLvz5LLXx27sFVZ7//Rn16
# 7Ca88kzF9SUenF+ulV0HmVgR02b69w74izVII/Hh3pPkv4T2m98DeXlnHdyuc3Lb
# bWggM2pf1Yr/jUOPtscQ9IqKTdYTLKqaErVSQJYabG9lLXRerXLj8mhH/W070jzT
# hZwp+5VJzF/OykiM0PW/tI5a0Upg8/8w/LRPwuqP0nFsW5QYdAQXSFbtsUfVdPlE
# Htk66xoQTLJ2a38m5WCvaRL97psGHmVXuWq0VUByNCAlWv6EiAAbTZBimIo4FZj+
# Ps6e7Tnvhv5kai2qZ4ijxJq88n9/mv8t0s/oD/BoGQMXmNn+87bR18byY5NZWi/4
# CKk60zbmgo8fGZ/zzwk4T+48I3SLfM+wnHePYs8nrHgoqGVEUXsCdXUYifxIcpel
# Vnb1OHXN3n+U8LnleQ158oQcSVFicvwQMBkzM+mW16WMQlReRRM=
# =GvNm
# -----END PGP SIGNATURE-----
# gpg: Signature made Thu 04 May 2023 10:48:49 AM BST
# gpg:                using RSA key C2C2C109EA43C63C1423EB84EF5D5E8161BA84E7
# gpg: Good signature from "Kostiantyn Kostiuk (Upstream PR sign) 
<kkostiuk@redhat.com>" [unknown]
# gpg: WARNING: This key is not certified with a trusted signature!
# gpg:          There is no indication that the signature belongs to the owner.
# Primary key fingerprint: C2C2 C109 EA43 C63C 1423  EB84 EF5D 5E81 61BA 84E7

* tag 'qga-pull-2023-05-04' of https://github.com/kostyanf14/qemu:
  qga: Fix suspend on Linux guests without systemd
  qga/commands-win32.c: Drop the check for _WIN32_WINNT >= 0x0601
  qga: test: Add tests for `merged` flag
  qga: Add `merged` variant to GuestExecCaptureOutputMode
  qga: Refactor guest-exec capture-output to take enum
  qga/linux: add usb support to guest-get-fsinfo

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


Compare: https://github.com/qemu/qemu/compare/1488ccb9b64e...f6b761bdbd8b