[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] 87511b: hw/gpio/aspeed: Add reg_table_count t
From: |
Richard Henderson |
Subject: |
[Qemu-commits] [qemu/qemu] 87511b: hw/gpio/aspeed: Add reg_table_count to AspeedGPIOC... |
Date: |
Tue, 02 Jul 2024 09:52:58 -0700 |
Branch: refs/heads/staging
Home: https://github.com/qemu/qemu
Commit: 87511bb878b2fc6618bee71add5c28c4e3d36d60
https://github.com/qemu/qemu/commit/87511bb878b2fc6618bee71add5c28c4e3d36d60
Author: Zheyu Ma <zheyuma97@gmail.com>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/gpio/aspeed_gpio.c
M include/hw/gpio/aspeed_gpio.h
Log Message:
-----------
hw/gpio/aspeed: Add reg_table_count to AspeedGPIOClass
ASan detected a global-buffer-overflow error in the aspeed_gpio_read()
function. This issue occurred when reading beyond the bounds of the
reg_table.
To enhance the safety and maintainability of the Aspeed GPIO code, this commit
introduces a reg_table_count member to the AspeedGPIOClass structure. This
change ensures that the size of the GPIO register table is explicitly tracked
and initialized, reducing the risk of errors if new register tables are
introduced in the future.
Reproducer:
cat << EOF | qemu-system-aarch64 -display none \
-machine accel=qtest, -m 512M -machine ast1030-evb -qtest stdio
readq 0x7e780272
EOF
ASAN log indicating the issue:
==2602930==ERROR: AddressSanitizer: global-buffer-overflow on address
0x55a5da29e128 at pc 0x55a5d700dc62 bp 0x7fff096c4e90 sp 0x7fff096c4e88
READ of size 2 at 0x55a5da29e128 thread T0
#0 0x55a5d700dc61 in aspeed_gpio_read hw/gpio/aspeed_gpio.c:564:14
#1 0x55a5d933f3ab in memory_region_read_accessor system/memory.c:445:11
#2 0x55a5d92fba40 in access_with_adjusted_size system/memory.c:573:18
#3 0x55a5d92f842c in memory_region_dispatch_read1 system/memory.c:1426:16
#4 0x55a5d92f7b68 in memory_region_dispatch_read system/memory.c:1459:9
#5 0x55a5d9376ad1 in flatview_read_continue_step system/physmem.c:2836:18
#6 0x55a5d9376399 in flatview_read_continue system/physmem.c:2877:19
#7 0x55a5d93775b8 in flatview_read system/physmem.c:2907:12
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2355
Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Andrew Jeffery <andrew@codeconstruct.com.au>
Commit: 56a37eda93edafabcc4de0184b88d082ede6dec1
https://github.com/qemu/qemu/commit/56a37eda93edafabcc4de0184b88d082ede6dec1
Author: Cédric Le Goater <clg@redhat.com>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M docs/about/deprecated.rst
M hw/arm/aspeed.c
Log Message:
-----------
aspeed: Deprecate the tacoma-bmc machine
The tacoma-bmc machine was a board including an AST2600 SoC based BMC
and a witherspoon like OpenPOWER system. It was used for bring up of
the AST2600 SoC in labs. It can be easily replaced by the rainier-bmc
machine which is part of a real product offering.
Signed-off-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Commit: 61578d1e806d7271813c870e31160a7b21eab508
https://github.com/qemu/qemu/commit/61578d1e806d7271813c870e31160a7b21eab508
Author: Cédric Le Goater <clg@redhat.com>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/misc/aspeed_sdmc.c
Log Message:
-----------
aspeed/sdmc: Check RAM size value at realize time
The RAM size of the SDMC device is validated for the SoC and set when
the Aspeed machines are initialized and then later used by several
SoC implementations. However, the SDMC model never checks that the RAM
size has been actually set before being used. Do that at realize.
Signed-off-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Jamin_lin < jamin_lin@aspeedtech.com>
Commit: 5c065dfc71b84179a9aec2d283bb57b5a5675b0b
https://github.com/qemu/qemu/commit/5c065dfc71b84179a9aec2d283bb57b5a5675b0b
Author: Jamin Lin <jamin_lin@aspeedtech.com>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/arm/aspeed_ast27x0.c
Log Message:
-----------
aspeed/soc: Fix possible divide by zero
Coverity reports a possible DIVIDE_BY_ZERO issue regarding the
"ram_size" object property. This can not happen because RAM has
predefined valid sizes per SoC. Nevertheless, add a test to
close the issue.
Fixes: Coverity CID 1547113
Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
[ clg: Rewrote commit log ]
Signed-off-by: Cédric Le Goater <clg@redhat.com>
Commit: 50c527b9ef58086dc377a0fa5e3053d16fc5728e
https://github.com/qemu/qemu/commit/50c527b9ef58086dc377a0fa5e3053d16fc5728e
Author: Jamin Lin <jamin_lin@aspeedtech.com>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/misc/aspeed_sdmc.c
Log Message:
-----------
aspeed/sdmc: Remove extra R_MAIN_STATUS case
Coverity reports that the newly added 'case R_MAIN_STATUS' is DEADCODE
because it can not be reached. This is because R_MAIN_STATUS is handled
before in the "Unprotected registers" switch statement. Remove it.
Fixes: Coverity CID 1547112
Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
[ clg: Rewrote commit log ]
Signed-off-by: Cédric Le Goater <clg@redhat.com>
Commit: 5b0961f7ad6790f473623703834351b6e43fbaa6
https://github.com/qemu/qemu/commit/5b0961f7ad6790f473623703834351b6e43fbaa6
Author: Jamin Lin <jamin_lin@aspeedtech.com>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/net/ftgmac100.c
Log Message:
-----------
hw/net:ftgmac100: fix coding style
Fix coding style issues from checkpatch.pl
Test command:
./scripts/checkpatch.pl --no-tree -f hw/net/ftgmac100.c
Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Commit: 6a414c01100359b799498a2a9f4f3883834df86e
https://github.com/qemu/qemu/commit/6a414c01100359b799498a2a9f4f3883834df86e
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M docs/about/deprecated.rst
Log Message:
-----------
hw/sd/sdcard: Deprecate support for spec v1.10
We use the v2.00 spec by default since commit 2f0939c234
("sdcard: Add a 'spec_version' property, default to Spec v2.00").
Time to deprecate the v1.10 which doesn't bring much, and
is not tested.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Tested-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240627071040.36190-2-philmd@linaro.org>
Commit: 702ff29c8ff397e6f3aa7e46f30f9ccdd74fb492
https://github.com/qemu/qemu/commit/702ff29c8ff397e6f3aa7e46f30f9ccdd74fb492
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Track last command used to help logging
The command is selected on the I/O lines, and further
processing might be done on the DAT lines via the
sd_read_byte() and sd_write_byte() handlers. Since
these methods can't distinct between normal and APP
commands, keep the name of the current command in
the SDState and use it in the DAT handlers. This
fixes a bug that all normal commands were displayed
as APP commands.
Fixes: 2ed61fb57b ("sdcard: Display command name when tracing CMD/ACMD")
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-4-philmd@linaro.org>
Commit: c159de66f29f7f0e6f7739d8722b54e0cb3cb971
https://github.com/qemu/qemu/commit/c159de66f29f7f0e6f7739d8722b54e0cb3cb971
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
M hw/sd/trace-events
Log Message:
-----------
hw/sd/sdcard: Trace block offset in READ/WRITE data accesses
Useful to detect out of bound accesses.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Tested-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-5-philmd@linaro.org>
Commit: 2ec83d679e1900aee7ac38f2a9acd6debae05557
https://github.com/qemu/qemu/commit/2ec83d679e1900aee7ac38f2a9acd6debae05557
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
M hw/sd/trace-events
Log Message:
-----------
hw/sd/sdcard: Trace requested address computed by sd_req_get_address()
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Luc Michel <luc.michel@amd.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-6-philmd@linaro.org>
Commit: c239084f5b2b13e74716071a5e029329a52e643a
https://github.com/qemu/qemu/commit/c239084f5b2b13e74716071a5e029329a52e643a
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Restrict SWITCH_FUNCTION to sd_transfer_state (CMD6)
SWITCH_FUNCTION is only allowed in TRANSFER state
(See 4.8 "Card State Transition Table).
Fixes: a1bb27b1e9 ("Initial SD card emulation")
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-13-philmd@linaro.org>
Commit: e55cbe727b07f1c39f57c1af842ff2fca9bc2d4a
https://github.com/qemu/qemu/commit/e55cbe727b07f1c39f57c1af842ff2fca9bc2d4a
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Send WRITE_PROT bits MSB first (CMD30)
Per sections 3.6.1 (SD Bus Protocol) and 7.3.2 (Responses):
In the CMD line the Most Significant Bit is transmitted first.
Use the stl_be_p() helper to store the value in big-endian.
Fixes: a1bb27b1e9 ("Initial SD card emulation")
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20240628070216.92609-8-philmd@linaro.org>
Commit: 7028187bd003f62e11f41cc8c6a26c1c12755cad
https://github.com/qemu/qemu/commit/7028187bd003f62e11f41cc8c6a26c1c12755cad
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Send NUM_WR_BLOCKS bits MSB first (ACMD22)
Per sections 3.6.1 (SD Bus Protocol), 4.3.4 "Data Write"
and 7.3.2 (Responses):
In the CMD line the Most Significant Bit is transmitted first.
Use the stl_be_p() helper to store the value in big-endian.
Fixes: a1bb27b1e9 ("Initial SD card emulation")
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20240628070216.92609-9-philmd@linaro.org>
Commit: 854f5bc655aaca38d3e05b795c500c4b27cfa070
https://github.com/qemu/qemu/commit/854f5bc655aaca38d3e05b795c500c4b27cfa070
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Use READY_FOR_DATA definition instead of magic value
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-10-philmd@linaro.org>
Commit: 26be1ceee5c5d0b01ebadc271807e6fb870670e7
https://github.com/qemu/qemu/commit/26be1ceee5c5d0b01ebadc271807e6fb870670e7
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Assign SDCardStates enum values
SDCardStates enum values are specified, so assign them
correspondingly. It will be useful later when we add
states from later specs, which might not be continuous.
See CURRENT_STATE bits in section 4.10.1 "Card Status".
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-11-philmd@linaro.org>
Commit: 257e36c9e602b5d10927292d38a9c85c5738683a
https://github.com/qemu/qemu/commit/257e36c9e602b5d10927292d38a9c85c5738683a
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Simplify sd_inactive_state handling
Card entering sd_inactive_state powers off, and won't respond
anymore. Handle that once when entering sd_do_command().
Remove condition always true in sd_cmd_GO_IDLE_STATE().
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-12-philmd@linaro.org>
Commit: 12160bebd4ed928fb4decdde4c4adc6af044839f
https://github.com/qemu/qemu/commit/12160bebd4ed928fb4decdde4c4adc6af044839f
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Add direct reference to SDProto in SDState
Keep direct reference to SDProto in SDState,
remove then unnecessary sd_proto().
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-14-philmd@linaro.org>
Commit: cb49e2ca22b830f0ca2752118b0bd01981e02bf3
https://github.com/qemu/qemu/commit/cb49e2ca22b830f0ca2752118b0bd01981e02bf3
Author: Philippe Mathieu-Daudé <f4bug@amsat.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Extract sd_blk_len() helper
Extract sd_blk_len() helper, use definitions instead
of magic values.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-15-philmd@linaro.org>
Commit: d45c3d7e1a3a530d39f7000e9c9259217b9a47ce
https://github.com/qemu/qemu/commit/d45c3d7e1a3a530d39f7000e9c9259217b9a47ce
Author: Cédric Le Goater <clg@kaod.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sdmmc-internal.h
Log Message:
-----------
hw/sd/sdcard: Introduce definitions for EXT_CSD register
Signed-off-by: Cédric Le Goater <clg@kaod.org>
Signed-off-by: Cédric Le Goater <clg@redhat.com>
Co-Developed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <20240628070216.92609-18-philmd@linaro.org>
Commit: f486bf7d1092bb9ec45dab123a3cdf6aaa18ea30
https://github.com/qemu/qemu/commit/f486bf7d1092bb9ec45dab123a3cdf6aaa18ea30
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Introduce sd_cmd_to_sendingdata and sd_generic_read_byte
All commands switching from TRANSFER state to (sending)DATA
do the same: send stream of data on the DAT lines. Instead
of duplicating the same code many times, introduce 2 helpers:
- sd_cmd_to_sendingdata() on the I/O line setup the data to
be transferred,
- sd_generic_read_byte() on the DAT lines to fetch the data.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <4c9f7f51-83ee-421a-8690-9af2e80b134b@linaro.org>
Commit: 1544e9f41dbfe1246611d86629d1c7ed1e3d0817
https://github.com/qemu/qemu/commit/1544e9f41dbfe1246611d86629d1c7ed1e3d0817
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Convert SWITCH_FUNCTION to generic_read_byte (CMD6)
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-20-philmd@linaro.org>
Commit: 374c93ecea604dd3fb675d6306644875922d56ff
https://github.com/qemu/qemu/commit/374c93ecea604dd3fb675d6306644875922d56ff
Author: Philippe Mathieu-Daudé <f4bug@amsat.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Convert SEND_CSD/SEND_CID to generic_read_byte (CMD9 & 10)
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-21-philmd@linaro.org>
Commit: eef0d42995c0638c336ae0ceb4e487b409094250
https://github.com/qemu/qemu/commit/eef0d42995c0638c336ae0ceb4e487b409094250
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Duplicate READ_SINGLE_BLOCK / READ_MULTIPLE_BLOCK cases
In order to modify the READ_SINGLE_BLOCK case in the
next commit, duplicate it first.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-22-philmd@linaro.org>
Commit: e7a73713f821c017f71554f1d42c51698be18310
https://github.com/qemu/qemu/commit/e7a73713f821c017f71554f1d42c51698be18310
Author: Philippe Mathieu-Daudé <f4bug@amsat.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Convert READ_SINGLE_BLOCK to generic_read_byte (CMD17)
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-23-philmd@linaro.org>
Commit: 060f0dac8668937a303120d0be0936ac6b29ce13
https://github.com/qemu/qemu/commit/060f0dac8668937a303120d0be0936ac6b29ce13
Author: Philippe Mathieu-Daudé <f4bug@amsat.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Convert SEND_TUNING_BLOCK to generic_read_byte (CMD19)
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-24-philmd@linaro.org>
Commit: 2c67f8e707c27b13f1db4cc16ea6bddcccfa1ed4
https://github.com/qemu/qemu/commit/2c67f8e707c27b13f1db4cc16ea6bddcccfa1ed4
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Convert SEND_WRITE_PROT to generic_read_byte (CMD30)
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-25-philmd@linaro.org>
Commit: ca24559d2c0df2d354e1ae329582de94817cd992
https://github.com/qemu/qemu/commit/ca24559d2c0df2d354e1ae329582de94817cd992
Author: Philippe Mathieu-Daudé <f4bug@amsat.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Convert SD_STATUS to generic_read_byte (ACMD13)
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-27-philmd@linaro.org>
Commit: 4d842275e28d47788e7c0c34ee52ee33708b5f39
https://github.com/qemu/qemu/commit/4d842275e28d47788e7c0c34ee52ee33708b5f39
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Convert SEND_NUM_WR_BLOCKS to generic_read_byte (ACMD22)
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-28-philmd@linaro.org>
Commit: a320f9c06748f19012ee23e4f5a471f1e04554fc
https://github.com/qemu/qemu/commit/a320f9c06748f19012ee23e4f5a471f1e04554fc
Author: Philippe Mathieu-Daudé <f4bug@amsat.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Convert SEND_SCR to generic_read_byte (ACMD51)
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-29-philmd@linaro.org>
Commit: 740d51d1a3132c31594f3ff5fb63d6fcc22607ef
https://github.com/qemu/qemu/commit/740d51d1a3132c31594f3ff5fb63d6fcc22607ef
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Introduce sd_cmd_to_receivingdata / sd_generic_write_byte
All commands switching from TRANSFER state to (receiving)DATA
do the same: receive stream of data from the DAT lines. Instead
of duplicating the same code many times, introduce 2 helpers:
- sd_cmd_to_receivingdata() on the I/O line setup the data to
be received on the data[] buffer,
- sd_generic_write_byte() on the DAT lines to push the data.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-30-philmd@linaro.org>
Commit: dba4b37b38317ed5f91e04ca95f3731c946dba5d
https://github.com/qemu/qemu/commit/dba4b37b38317ed5f91e04ca95f3731c946dba5d
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Duplicate WRITE_SINGLE_BLOCK / WRITE_MULTIPLE_BLOCK cases
In order to modify the WRITE_SINGLE_BLOCK case in the
next commit, duplicate it first.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-31-philmd@linaro.org>
Commit: 540c1832dde061f15697112f49d766f9ba589794
https://github.com/qemu/qemu/commit/540c1832dde061f15697112f49d766f9ba589794
Author: Philippe Mathieu-Daudé <f4bug@amsat.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Convert WRITE_SINGLE_BLOCK to generic_write_byte (CMD24)
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-32-philmd@linaro.org>
Commit: dbccae20f76ddfcade41bb5a746ec88dc90b27f3
https://github.com/qemu/qemu/commit/dbccae20f76ddfcade41bb5a746ec88dc90b27f3
Author: Philippe Mathieu-Daudé <f4bug@amsat.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Convert PROGRAM_CID to generic_write_byte (CMD26)
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-33-philmd@linaro.org>
Commit: a182208e5db658dfa71506e3e0ff9a698d08a972
https://github.com/qemu/qemu/commit/a182208e5db658dfa71506e3e0ff9a698d08a972
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Convert PROGRAM_CSD to generic_write_byte (CMD27)
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-34-philmd@linaro.org>
Commit: 77a2f97d1d1390d493a881983123bff5d04ead9a
https://github.com/qemu/qemu/commit/77a2f97d1d1390d493a881983123bff5d04ead9a
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Convert LOCK_UNLOCK to generic_write_byte (CMD42)
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-35-philmd@linaro.org>
Commit: d4613f9f40a355e5f99268ac9daf7ad14764e99f
https://github.com/qemu/qemu/commit/d4613f9f40a355e5f99268ac9daf7ad14764e99f
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/meson.build
M hw/sd/sd.c
R hw/sd/sdmmc-internal.c
M hw/sd/sdmmc-internal.h
Log Message:
-----------
hw/sd/sdcard: Move sd_[a]cmd_name() methods to sd.c
Merge sdmmc-internal.c into sd.c by moving
sd_cmd_name() and sd_acmd_name() and updating
meson.build.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-37-philmd@linaro.org>
Commit: fb72e681c9caccc5f9effce219447cae1ed05c9d
https://github.com/qemu/qemu/commit/fb72e681c9caccc5f9effce219447cae1ed05c9d
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Pass SDState as argument to sd_[a]cmd_name()
In order to access SDState::SDProto from sd_[a]cmd_name(),
pass SDState as argument.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-38-philmd@linaro.org>
Commit: 4518a49a019648110a84d7decebd46a12c229a32
https://github.com/qemu/qemu/commit/4518a49a019648110a84d7decebd46a12c229a32
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Prepare SDProto to contain more fields
Convert array of command handlers to array of structures.
The structure contains the command handler. No logical
change intended.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-39-philmd@linaro.org>
Commit: 572cdb1d9092e165d34f4ff8ab5483a97c6a99a2
https://github.com/qemu/qemu/commit/572cdb1d9092e165d34f4ff8ab5483a97c6a99a2
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Store command name in SDProto
We already have a const array where command handlers
are listed. Store the command name there too.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-40-philmd@linaro.org>
Commit: 1ab08790bb75e40cf35002edc26672d6b0e8004e
https://github.com/qemu/qemu/commit/1ab08790bb75e40cf35002edc26672d6b0e8004e
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
M include/hw/sd/sd.h
Log Message:
-----------
hw/sd/sdcard: Store command type in SDProto
Store the command type altogether with the command handler and name.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-41-philmd@linaro.org>
Commit: de32f0aa9a53db5d4cac8e9a5944c688b0ab24a2
https://github.com/qemu/qemu/commit/de32f0aa9a53db5d4cac8e9a5944c688b0ab24a2
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Store command class in SDProto
Store the command class altogether with the other command
fields (handler, name and type).
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-42-philmd@linaro.org>
Commit: 617c5a734571145f65423336376001bac8fc371a
https://github.com/qemu/qemu/commit/617c5a734571145f65423336376001bac8fc371a
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Remove SEND_DSR dead case (CMD4)
The CSD::CSR_IMP bit defines whether the Driver Stage
Register (DSR) is implemented or not. We do not set
this bit in CSD:
static void sd_set_csd(SDState *sd, uint64_t size)
{
...
if (size <= SDSC_MAX_CAPACITY) { /* Standard Capacity SD */
...
sd->csd[6] = 0xe0 | /* Partial block for read allowed */
((csize >> 10) & 0x03);
...
} else { /* SDHC */
...
sd->csd[6] = 0x00;
...
}
...
}
The sd_normal_command() switch case for the SEND_DSR
command do nothing and fallback to "illegal command".
Since the command is mandatory (although the register
isn't...) call the sd_cmd_unimplemented() handler.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-43-philmd@linaro.org>
Commit: 720c0f3e6cf856fa62c06a8f0005d814684c30d9
https://github.com/qemu/qemu/commit/720c0f3e6cf856fa62c06a8f0005d814684c30d9
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Register generic optional handlers (CMD11 and CMD20)
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-44-philmd@linaro.org>
Commit: a3e8ca8381aff3b115103c29f0b8f2265705e90c
https://github.com/qemu/qemu/commit/a3e8ca8381aff3b115103c29f0b8f2265705e90c
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Register optional handlers from spec v6.00
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-45-philmd@linaro.org>
Commit: 9b2e17756f08849a20b4989aec1e7a29520f5ea0
https://github.com/qemu/qemu/commit/9b2e17756f08849a20b4989aec1e7a29520f5ea0
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Register SDIO optional handlers
See "SD Input/Output Card Specification" v1.00.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-46-philmd@linaro.org>
Commit: f274e6f59042f92746474c658d3a413342694bca
https://github.com/qemu/qemu/commit/f274e6f59042f92746474c658d3a413342694bca
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Register Security Extension optional handlers
See "Advanced Security SD Extension Specification" v2.00.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-47-philmd@linaro.org>
Commit: 4064824fb7781fce85ed50e56611241eb16ce83d
https://github.com/qemu/qemu/commit/4064824fb7781fce85ed50e56611241eb16ce83d
Author: Philippe Mathieu-Daudé <f4bug@amsat.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Add sd_cmd_SWITCH_FUNCTION handler (CMD6)
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-48-philmd@linaro.org>
Commit: 9193deb4066ad3734f27e7fbe3717ad80db0f16e
https://github.com/qemu/qemu/commit/9193deb4066ad3734f27e7fbe3717ad80db0f16e
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Add sd_cmd_DE/SELECT_CARD handler (CMD7)
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-49-philmd@linaro.org>
Commit: 31798907b71f9fd15aa2ccb20b2f18e782d8a3bc
https://github.com/qemu/qemu/commit/31798907b71f9fd15aa2ccb20b2f18e782d8a3bc
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Add sd_cmd_SEND_IF_COND handler (CMD8)
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-50-philmd@linaro.org>
Commit: 1ec3cb893fa8883f5baf69850a4d0a97502bbad8
https://github.com/qemu/qemu/commit/1ec3cb893fa8883f5baf69850a4d0a97502bbad8
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Add sd_cmd_SEND_CSD/CID handlers (CMD9 & CMD10)
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-51-philmd@linaro.org>
Commit: da954d0e32444f122a41c24948d4d1c718bf66d4
https://github.com/qemu/qemu/commit/da954d0e32444f122a41c24948d4d1c718bf66d4
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Add spi_cmd_SEND_CSD/CID handlers (CMD9 & CMD10)
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-52-philmd@linaro.org>
Commit: 030897e89d3dff8ef7efd5cc570612da4476734f
https://github.com/qemu/qemu/commit/030897e89d3dff8ef7efd5cc570612da4476734f
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Add sd_cmd_STOP_TRANSMISSION handler (CMD12)
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-53-philmd@linaro.org>
Commit: 807f6adac3773c18772bfc9dbee7a3b4a4f9dfe0
https://github.com/qemu/qemu/commit/807f6adac3773c18772bfc9dbee7a3b4a4f9dfe0
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Add sd_cmd_SEND_STATUS handler (CMD13)
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-54-philmd@linaro.org>
Commit: 9318be060506be33a0fbf01198b0024fdeb28f39
https://github.com/qemu/qemu/commit/9318be060506be33a0fbf01198b0024fdeb28f39
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Add sd_cmd_GO_INACTIVE_STATE handler (CMD15)
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-55-philmd@linaro.org>
Commit: 6d4e6424a6f7dbc11d06b231d9993958fcc1f929
https://github.com/qemu/qemu/commit/6d4e6424a6f7dbc11d06b231d9993958fcc1f929
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Add sd_cmd_SET_BLOCKLEN handler (CMD16)
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-56-philmd@linaro.org>
Commit: 3d3caf2021a355e4f5ffa635d4942beddf6ea1fa
https://github.com/qemu/qemu/commit/3d3caf2021a355e4f5ffa635d4942beddf6ea1fa
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Add sd_cmd_READ_SINGLE_BLOCK handler (CMD17)
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-57-philmd@linaro.org>
Commit: 4f862e6409ea3756a59dd1bde6b7e8303916ff23
https://github.com/qemu/qemu/commit/4f862e6409ea3756a59dd1bde6b7e8303916ff23
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Add sd_cmd_WRITE_SINGLE_BLOCK handler (CMD24)
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-58-philmd@linaro.org>
Commit: 96f3d00ac1680f978984314d24ae6f2f6f281fdc
https://github.com/qemu/qemu/commit/96f3d00ac1680f978984314d24ae6f2f6f281fdc
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Add sd_cmd_PROGRAM_CSD handler (CMD27)
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-59-philmd@linaro.org>
Commit: 4194922b6fc9af3e3b4987dbf9c90db3aa10d3af
https://github.com/qemu/qemu/commit/4194922b6fc9af3e3b4987dbf9c90db3aa10d3af
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Add sd_cmd_SET/CLR_WRITE_PROT handler (CMD28 & CMD29)
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-60-philmd@linaro.org>
Commit: ff47c3593de92f9c583f346586691f86545b605a
https://github.com/qemu/qemu/commit/ff47c3593de92f9c583f346586691f86545b605a
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Add sd_cmd_SEND_WRITE_PROT handler (CMD30)
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-61-philmd@linaro.org>
Commit: b633bf2b45ff6aa396be8bf693c4b8ae2ce83485
https://github.com/qemu/qemu/commit/b633bf2b45ff6aa396be8bf693c4b8ae2ce83485
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Add sd_cmd_ERASE_WR_BLK_START/END handlers (CMD32 & CMD33)
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-62-philmd@linaro.org>
Commit: 1dfa77d4e63b7794d7bb9a81f2b6b26a1af082d8
https://github.com/qemu/qemu/commit/1dfa77d4e63b7794d7bb9a81f2b6b26a1af082d8
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Add sd_cmd_ERASE handler (CMD38)
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-63-philmd@linaro.org>
Commit: 29d247ad63a7cfc0c3b2ec2662c71853e35d6a17
https://github.com/qemu/qemu/commit/29d247ad63a7cfc0c3b2ec2662c71853e35d6a17
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Add sd_cmd_LOCK_UNLOCK handler (CMD42)
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-64-philmd@linaro.org>
Commit: a171b753365d308b98d5e4db4dafa55369eea917
https://github.com/qemu/qemu/commit/a171b753365d308b98d5e4db4dafa55369eea917
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Add sd_cmd_APP_CMD handler (CMD55)
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-65-philmd@linaro.org>
Commit: 8aaae7fd191cdb7f72d2d8956d92d3acaf7cd7a4
https://github.com/qemu/qemu/commit/8aaae7fd191cdb7f72d2d8956d92d3acaf7cd7a4
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Add spi_cmd_READ_OCR handler (CMD58)
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-67-philmd@linaro.org>
Commit: 95e9305bf9422781ba10fbb327e4b5e13aa1e450
https://github.com/qemu/qemu/commit/95e9305bf9422781ba10fbb327e4b5e13aa1e450
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Add spi_cmd_CRC_ON_OFF handler (CMD59)
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-68-philmd@linaro.org>
Commit: 55f2645eab67e712da2a776e5798412e37ae488c
https://github.com/qemu/qemu/commit/55f2645eab67e712da2a776e5798412e37ae488c
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Add sd_acmd_SET_BUS_WIDTH handler (ACMD6)
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-69-philmd@linaro.org>
Commit: cc7c6bda3f16fc8c91daa38b1c96506e49fcc50d
https://github.com/qemu/qemu/commit/cc7c6bda3f16fc8c91daa38b1c96506e49fcc50d
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Add sd_acmd_SD_STATUS handler (ACMD13)
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-70-philmd@linaro.org>
Commit: 225e70fb218b274f1175af515230619dda4c7163
https://github.com/qemu/qemu/commit/225e70fb218b274f1175af515230619dda4c7163
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Add sd_acmd_SEND_NUM_WR_BLOCKS handler (ACMD22)
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-71-philmd@linaro.org>
Commit: f443003ff43a6473da0499393dfb11a4b9b4bd07
https://github.com/qemu/qemu/commit/f443003ff43a6473da0499393dfb11a4b9b4bd07
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Add sd_acmd_SET_WR_BLK_ERASE_COUNT handler (ACMD23)
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-72-philmd@linaro.org>
Commit: c79cbe44ec5a6c2c50ae1fde73e029d4c0386758
https://github.com/qemu/qemu/commit/c79cbe44ec5a6c2c50ae1fde73e029d4c0386758
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Add sd_acmd_SD_APP_OP_COND handler (ACMD41)
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-73-philmd@linaro.org>
Commit: 7614306f2a67bf395472921ed7f16c7fcded0db9
https://github.com/qemu/qemu/commit/7614306f2a67bf395472921ed7f16c7fcded0db9
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Add sd_acmd_SET_CLR_CARD_DETECT handler (ACMD42)
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-74-philmd@linaro.org>
Commit: 8442e1625ba6723bee2c6d0fdb7207a3e27a2b05
https://github.com/qemu/qemu/commit/8442e1625ba6723bee2c6d0fdb7207a3e27a2b05
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Add sd_acmd_SEND_SCR handler (ACMD51)
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-75-philmd@linaro.org>
Commit: 8a2b8894d2a9eb6fba7e2a533f932a8781391030
https://github.com/qemu/qemu/commit/8a2b8894d2a9eb6fba7e2a533f932a8781391030
Author: Richard Henderson <richard.henderson@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M docs/about/deprecated.rst
M hw/arm/aspeed.c
M hw/arm/aspeed_ast27x0.c
M hw/gpio/aspeed_gpio.c
M hw/misc/aspeed_sdmc.c
M hw/net/ftgmac100.c
M include/hw/gpio/aspeed_gpio.h
Log Message:
-----------
Merge tag 'pull-aspeed-20240702' of https://github.com/legoater/qemu into
staging
aspeed queue:
* Coverity fixes
* Deprecation of tacoma-bmc machine
* Buffer overflow fix in GPIO model
* Minor cleanup
# -----BEGIN PGP SIGNATURE-----
#
# iQIzBAABCAAdFiEEoPZlSPBIlev+awtgUaNDx8/77KEFAmaDs3QACgkQUaNDx8/7
# 7KEc/BAAj5AS3rLm3NPpU13y1P1hcjuSm1/PVGTJQH+m4K9UaAkJ8VhRB0Y/rdU6
# ygGhKaCHyk96+I49Csz886YU9Wg9qnxaYJAbornHZJVGNy5tuVpQKM20kfgN3XFN
# ENJR3e+J6Ye7kCtR1ujcf0mydWDaDyq0i82ykURsudcQLMnGq1gBQGadYjt1hJoN
# F9HDPgUJ8/wjQnG8BomsrnuvUSpRTbGNV66FNxXdQ6C6d6OTKQfNnXXqrKO+8QPK
# B5XB9FjTk017DUog1jdE1SaEMowml8CmUhjMwLHOcyWhcZpEk90aMX8cQhefUs9y
# O6kNin2UYEjcTHA/lyfMQJQMNDDZTE32MyP1LwRE/5ZiHqrT7ViqNvZSPBGBueUz
# 9B0xiQTuYqcRqlwgyU73DvnTgrsKFdKQSldj5dXYVnWCKeKY/sCWApHMJxN9xMCA
# Uw1E4QfCLkd+TM6DoJAkBHWFsgi44Aym11VU4VviGNRNTgmTptgQzmHiYGNFiGZG
# OypVPM8Ti6UeVnW65l9J9f7xA0jDB+XQjhCCaoax9GlUMA4C4/Aln5OXXxIWRWFd
# XA3Gn3c/S2j7rMqdfAk68xDHuAJ3wShHlw6HLRd1Xki05WFTeLj1lejLHMdfpNmr
# DkQimzHShBqZzZGxc7FsO0keGY8kyIJkZhbCCbZrFXJXQGRdBao=
# =LxwO
# -----END PGP SIGNATURE-----
# gpg: Signature made Tue 02 Jul 2024 12:59:48 AM PDT
# gpg: using RSA key A0F66548F04895EBFE6B0B6051A343C7CFFBECA1
# gpg: Good signature from "Cédric Le Goater <clg@kaod.org>" [undefined]
# gpg: WARNING: This key is not certified with a trusted signature!
# gpg: There is no indication that the signature belongs to the owner.
# Primary key fingerprint: A0F6 6548 F048 95EB FE6B 0B60 51A3 43C7 CFFB ECA1
* tag 'pull-aspeed-20240702' of https://github.com/legoater/qemu:
hw/net:ftgmac100: fix coding style
aspeed/sdmc: Remove extra R_MAIN_STATUS case
aspeed/soc: Fix possible divide by zero
aspeed/sdmc: Check RAM size value at realize time
aspeed: Deprecate the tacoma-bmc machine
hw/gpio/aspeed: Add reg_table_count to AspeedGPIOClass
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Commit: 6746482d12da3b6e4d3cdf06481a0027a797f719
https://github.com/qemu/qemu/commit/6746482d12da3b6e4d3cdf06481a0027a797f719
Author: Richard Henderson <richard.henderson@linaro.org>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M docs/about/deprecated.rst
M hw/sd/meson.build
M hw/sd/sd.c
R hw/sd/sdmmc-internal.c
M hw/sd/sdmmc-internal.h
M hw/sd/trace-events
M include/hw/sd/sd.h
Log Message:
-----------
Merge tag 'sdmmc-20240702' of https://github.com/philmd/qemu into staging
SD/MMC patches queue
- Deprecate SD spec v1.10
- Improve tracing
- Fix endianness on DAT lines
- Introduce helpers for commands transmitting data on the DAT lines
- Convert most commands to new helpers
- Register various optional commands
- Add command {name, type, class} fields to SDProto structure
# -----BEGIN PGP SIGNATURE-----
#
# iQIzBAABCAAdFiEE+qvnXhKRciHc/Wuy4+MsLN6twN4FAmaDtrEACgkQ4+MsLN6t
# wN7wABAAjjo+8ZYTxyh+P5oPvv4ec0SLFyTzOyDlzl/8rif9l54UP1kvBGtDYBaF
# hdHM/BguTQVdomObCrjmcXLmb/+ZnQ23x8Bn8rm1mqjXmV8UvuZ9KReAhQeEgBNN
# rtWClQqgtuBAbhh2uh0zNmwPhzCavSostd5nQtJXvUfCZUIyTmUBqUNFCZc+RkGy
# q6kUDzlgrH7uLzVMU5M6QvmOT1LbmWGQAdV+zWXBKXEBgysxzmm6bC7wRCoN+wPQ
# 9OtdHEZsxEDaIJFK7YcDu0lCOsGFzu62d8N7TA/v4nIWaxrppm4FK7kxgmsO15uY
# jEq3p2PbDj6UVYrqGpuw4qMcJ0Cs6dkGEfCw9eqwYyhAPd/Y+s/NBAgc6BieZWj6
# D32goEWykLorxu9sPGgR9qNWo7gbHanMo4ps3v4++D8Qtb3CpANXDIC5H1WR9azH
# tdiepDx0nW9bSo/hE32bL70TA8noqUCsrr1yIN7eydpJ2ZTa2ywMfIifLnowoOD2
# mPQ/QvUsAwJdjGXsz21loQdycOsuBmqZ4bKU45ez3bxKdq1LFC4q6xsVPeS0UVFy
# 6dSj2Bi44Y+Ub/UoNij2/6WzuIfNtSKXrs47et2v2SFjuPJt0g34cv3mLCz6CQQZ
# 2WFk42vyGSZ9gmWmt+G64nksQlifVWnGQP6jub9ThQ5rxqzFTU0=
# =vqY+
# -----END PGP SIGNATURE-----
# gpg: Signature made Tue 02 Jul 2024 01:13:37 AM PDT
# gpg: using RSA key FAABE75E12917221DCFD6BB2E3E32C2CDEADC0DE
# gpg: Good signature from "Philippe Mathieu-Daudé (F4BUG) <f4bug@amsat.org>"
[full]
* tag 'sdmmc-20240702' of https://github.com/philmd/qemu: (67 commits)
hw/sd/sdcard: Add sd_acmd_SEND_SCR handler (ACMD51)
hw/sd/sdcard: Add sd_acmd_SET_CLR_CARD_DETECT handler (ACMD42)
hw/sd/sdcard: Add sd_acmd_SD_APP_OP_COND handler (ACMD41)
hw/sd/sdcard: Add sd_acmd_SET_WR_BLK_ERASE_COUNT handler (ACMD23)
hw/sd/sdcard: Add sd_acmd_SEND_NUM_WR_BLOCKS handler (ACMD22)
hw/sd/sdcard: Add sd_acmd_SD_STATUS handler (ACMD13)
hw/sd/sdcard: Add sd_acmd_SET_BUS_WIDTH handler (ACMD6)
hw/sd/sdcard: Add spi_cmd_CRC_ON_OFF handler (CMD59)
hw/sd/sdcard: Add spi_cmd_READ_OCR handler (CMD58)
hw/sd/sdcard: Add sd_cmd_APP_CMD handler (CMD55)
hw/sd/sdcard: Add sd_cmd_LOCK_UNLOCK handler (CMD42)
hw/sd/sdcard: Add sd_cmd_ERASE handler (CMD38)
hw/sd/sdcard: Add sd_cmd_ERASE_WR_BLK_START/END handlers (CMD32 & CMD33)
hw/sd/sdcard: Add sd_cmd_SEND_WRITE_PROT handler (CMD30)
hw/sd/sdcard: Add sd_cmd_SET/CLR_WRITE_PROT handler (CMD28 & CMD29)
hw/sd/sdcard: Add sd_cmd_PROGRAM_CSD handler (CMD27)
hw/sd/sdcard: Add sd_cmd_WRITE_SINGLE_BLOCK handler (CMD24)
hw/sd/sdcard: Add sd_cmd_READ_SINGLE_BLOCK handler (CMD17)
hw/sd/sdcard: Add sd_cmd_SET_BLOCKLEN handler (CMD16)
hw/sd/sdcard: Add sd_cmd_GO_INACTIVE_STATE handler (CMD15)
...
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Compare: https://github.com/qemu/qemu/compare/ff6d8490e33a...6746482d12da
To unsubscribe from these emails, change your notification settings at
https://github.com/qemu/qemu/settings/notifications
- [Qemu-commits] [qemu/qemu] 87511b: hw/gpio/aspeed: Add reg_table_count to AspeedGPIOC...,
Richard Henderson <=