[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] 661813: qga: drop blocking of guest-get-memor
|
From: |
Richard Henderson |
|
Subject: |
[Qemu-commits] [qemu/qemu] 661813: qga: drop blocking of guest-get-memory-block-size ... |
|
Date: |
Mon, 22 Jul 2024 14:36:04 -0700 |
Branch: refs/heads/staging
Home: https://github.com/qemu/qemu
Commit: 66181376200870ea53ba6c6488683cff1c8795b0
https://github.com/qemu/qemu/commit/66181376200870ea53ba6c6488683cff1c8795b0
Author: Daniel P. Berrangé <berrange@redhat.com>
Date: 2024-07-19 (Fri, 19 Jul 2024)
Changed paths:
M qga/commands-posix.c
M qga/commands-win32.c
Log Message:
-----------
qga: drop blocking of guest-get-memory-block-size command
This command has never existed in tree, since it was renamed to
guest-get-memory-block-info before being merged.
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20240712132459.3974109-2-berrange@redhat.com>
Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Commit: 4210027b5002e66a308d7c52b2e3204438c363cd
https://github.com/qemu/qemu/commit/4210027b5002e66a308d7c52b2e3204438c363cd
Author: Daniel P. Berrangé <berrange@redhat.com>
Date: 2024-07-19 (Fri, 19 Jul 2024)
Changed paths:
M qga/commands-linux.c
M qga/commands-posix.c
Log Message:
-----------
qga: move linux vcpu command impls to commands-linux.c
The qmp_guest_set_vcpus and qmp_guest_get_vcpus command impls in
commands-posix.c are surrounded by '#ifdef __linux__' so should
instead live in commands-linux.c
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Message-ID: <20240712132459.3974109-3-berrange@redhat.com>
Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Commit: 0c6f8824faa70d0782ce8b6a59d500bbd95acf64
https://github.com/qemu/qemu/commit/0c6f8824faa70d0782ce8b6a59d500bbd95acf64
Author: Daniel P. Berrangé <berrange@redhat.com>
Date: 2024-07-19 (Fri, 19 Jul 2024)
Changed paths:
M qga/commands-linux.c
M qga/commands-posix.c
Log Message:
-----------
qga: move linux suspend command impls to commands-linux.c
The qmp_guest_suspend_{disk,ram,hybrid} command impls in
commands-posix.c are surrounded by '#ifdef __linux__' so should
instead live in commands-linux.c
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Message-ID: <20240712132459.3974109-4-berrange@redhat.com>
Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Commit: 329cefe405e0b4e1e7a97ef84734dac82668a2d0
https://github.com/qemu/qemu/commit/329cefe405e0b4e1e7a97ef84734dac82668a2d0
Author: Daniel P. Berrangé <berrange@redhat.com>
Date: 2024-07-19 (Fri, 19 Jul 2024)
Changed paths:
M qga/commands-linux.c
M qga/commands-posix.c
Log Message:
-----------
qga: move linux fs/disk command impls to commands-linux.c
The qmp_guest_{fstrim, get_fsinfo, get_disks} command impls in
commands-posix.c are surrounded by '#ifdef __linux__' so should
instead live in commands-linux.c
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Message-ID: <20240712132459.3974109-5-berrange@redhat.com>
Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Commit: 74cbd9bcefb1781648cf593597018a05199d8ced
https://github.com/qemu/qemu/commit/74cbd9bcefb1781648cf593597018a05199d8ced
Author: Daniel P. Berrangé <berrange@redhat.com>
Date: 2024-07-19 (Fri, 19 Jul 2024)
Changed paths:
M qga/commands-linux.c
M qga/commands-posix.c
Log Message:
-----------
qga: move linux disk/cpu stats command impls to commands-linux.c
The qmp_guest_{diskstats,cpustats} command impls in
commands-posix.c are surrounded by '#ifdef __linux__' so should
instead live in commands-linux.c
This also removes a "#ifdef CONFIG_LINUX" that was nested inside
a "#ifdef __linux__".
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Message-ID: <20240712132459.3974109-6-berrange@redhat.com>
Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Commit: 8b93e5685f71be972b64f50cc5cdf9a02a2bb2ab
https://github.com/qemu/qemu/commit/8b93e5685f71be972b64f50cc5cdf9a02a2bb2ab
Author: Daniel P. Berrangé <berrange@redhat.com>
Date: 2024-07-19 (Fri, 19 Jul 2024)
Changed paths:
M qga/commands-linux.c
M qga/commands-posix.c
Log Message:
-----------
qga: move linux memory block command impls to commands-linux.c
The qmp_guest_{set,get}_{memory_blocks,block_info} command impls in
commands-posix.c are surrounded by '#ifdef __linux__' so should
instead live in commands-linux.c
This also removes a "#ifdef CONFIG_LINUX" that was nested inside
a "#ifdef __linux__".
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Message-ID: <20240712132459.3974109-7-berrange@redhat.com>
Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Commit: 4bb3da4b145b8cb51a71a429c8b7cb6392c0cdcc
https://github.com/qemu/qemu/commit/4bb3da4b145b8cb51a71a429c8b7cb6392c0cdcc
Author: Daniel P. Berrangé <berrange@redhat.com>
Date: 2024-07-19 (Fri, 19 Jul 2024)
Changed paths:
M meson.build
M qga/commands-common.h
Log Message:
-----------
qga: move CONFIG_FSFREEZE/TRIM to be meson defined options
Defining these at the meson level allows them to be used a conditional
tests in the QAPI schemas.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20240712132459.3974109-8-berrange@redhat.com>
Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Commit: 0e90127d9b385cca45b48117d4050fd2f57a49ea
https://github.com/qemu/qemu/commit/0e90127d9b385cca45b48117d4050fd2f57a49ea
Author: Daniel P. Berrangé <berrange@redhat.com>
Date: 2024-07-19 (Fri, 19 Jul 2024)
Changed paths:
M qga/commands-posix.c
M qga/commands-win32.c
M qga/qapi-schema.json
Log Message:
-----------
qga: conditionalize schema for commands unsupported on Windows
Rather than creating stubs for every command that just return
QERR_UNSUPPORTED, use 'if' conditions in the QAPI schema to
fully exclude generation of the commands on Windows.
The command will be rejected at QMP dispatch time instead,
avoiding reimplementing rejection by blocking the stub commands.
This changes the error message for affected commands from
{"class": "CommandNotFound", "desc": "Command FOO has been disabled"}
to
{"class": "CommandNotFound", "desc": "The command FOO has not been found"}
This also fixes an accidental inconsistency where some commands
(guest-get-diskstats & guest-get-cpustats) are implemented as
stubs, yet not added to the blockedrpc list. Those change their
error message from
{"class": "GenericError, "desc": "this feature or command is not currently
supported"}
to
{"class": "CommandNotFound", "desc": "The command FOO has not been found"}
The final additional benefit is that the QGA protocol reference
now documents what conditions enable use of the command.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Message-ID: <20240712132459.3974109-9-berrange@redhat.com>
Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Commit: dacc52461b045148d87606bada5cd24d1ca8c220
https://github.com/qemu/qemu/commit/dacc52461b045148d87606bada5cd24d1ca8c220
Author: Daniel P. Berrangé <berrange@redhat.com>
Date: 2024-07-19 (Fri, 19 Jul 2024)
Changed paths:
M qga/commands-posix.c
M qga/qapi-schema.json
Log Message:
-----------
qga: conditionalize schema for commands unsupported on non-Linux POSIX
Rather than creating stubs for every command that just return
QERR_UNSUPPORTED, use 'if' conditions in the QAPI schema to
fully exclude generation of the commands on non-Linux POSIX
platforms
The command will be rejected at QMP dispatch time instead,
avoiding reimplementing rejection by blocking the stub commands.
This changes the error message for affected commands from
{"class": "CommandNotFound", "desc": "Command FOO has been disabled"}
to
{"class": "CommandNotFound", "desc": "The command FOO has not been found"}
This has the additional benefit that the QGA protocol reference
now documents what conditions enable use of the command.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Message-ID: <20240712132459.3974109-10-berrange@redhat.com>
Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Commit: f8edff9b779bc39e71a832ad0b7d32184b057b5d
https://github.com/qemu/qemu/commit/f8edff9b779bc39e71a832ad0b7d32184b057b5d
Author: Daniel P. Berrangé <berrange@redhat.com>
Date: 2024-07-19 (Fri, 19 Jul 2024)
Changed paths:
M qga/commands-posix.c
M qga/qapi-schema.json
Log Message:
-----------
qga: conditionalize schema for commands requiring getifaddrs
Rather than creating stubs for every comamnd that just return
QERR_UNSUPPORTED, use 'if' conditions in the QAPI schema to
fully exclude generation of the network interface command on
POSIX platforms lacking getifaddrs().
The command will be rejected at QMP dispatch time instead,
avoiding reimplementing rejection by blocking the stub commands.
This changes the error message for affected commands from
{"class": "CommandNotFound", "desc": "Command FOO has been disabled"}
to
{"class": "CommandNotFound", "desc": "The command FOO has not been found"}
This has the additional benefit that the QGA protocol reference
now documents what conditions enable use of the command.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Message-ID: <20240712132459.3974109-11-berrange@redhat.com>
Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Commit: 83a7a1ab9af79396831fbb6df510c91e51d1d174
https://github.com/qemu/qemu/commit/83a7a1ab9af79396831fbb6df510c91e51d1d174
Author: Daniel P. Berrangé <berrange@redhat.com>
Date: 2024-07-19 (Fri, 19 Jul 2024)
Changed paths:
M qga/commands-bsd.c
M qga/commands-posix.c
M qga/qapi-schema.json
Log Message:
-----------
qga: conditionalize schema for commands requiring linux/win32
Some commands were blocked based on CONFIG_FSFREEZE, but their
impl had nothing todo with CONFIG_FSFREEZE, and were instead
either Linux-only, or Win+Linux-only.
Rather than creating stubs for every command that just return
QERR_UNSUPPORTED, use 'if' conditions in the QAPI schema to
fully exclude generation of the stats and fsinfo commands on
platforms that can't support them.
The command will be rejected at QMP dispatch time instead,
avoiding reimplementing rejection by blocking the stub commands.
This changes the error message for affected commands from
{"class": "CommandNotFound", "desc": "Command FOO has been disabled"}
to
{"class": "CommandNotFound", "desc": "The command FOO has not been found"}
This has the additional benefit that the QGA protocol reference
now documents what conditions enable use of the command.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Message-ID: <20240712132459.3974109-12-berrange@redhat.com>
Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Commit: dedf99f3032aa2968af55c62a5642ed3648ff58d
https://github.com/qemu/qemu/commit/dedf99f3032aa2968af55c62a5642ed3648ff58d
Author: Daniel P. Berrangé <berrange@redhat.com>
Date: 2024-07-19 (Fri, 19 Jul 2024)
Changed paths:
M qga/commands-posix.c
M qga/qapi-schema.json
Log Message:
-----------
qga: conditionalize schema for commands only supported on Windows
Rather than creating stubs for every command that just return
QERR_UNSUPPORTED, use 'if' conditions in the QAPI schema to
fully exclude generation of the commands on non-Windows.
The command will be rejected at QMP dispatch time instead,
avoiding reimplementing rejection by blocking the stub commands.
This changes the error message for affected commands from
{"class": "CommandNotFound", "desc": "Command FOO has been disabled"}
to
{"class": "CommandNotFound", "desc": "The command FOO has not been found"}
This has the additional benefit that the QGA protocol reference
now documents what conditions enable use of the command.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Message-ID: <20240712132459.3974109-13-berrange@redhat.com>
Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Commit: 49d8c8e2374e0ed10e8d510760bd993e311cfb1a
https://github.com/qemu/qemu/commit/49d8c8e2374e0ed10e8d510760bd993e311cfb1a
Author: Daniel P. Berrangé <berrange@redhat.com>
Date: 2024-07-19 (Fri, 19 Jul 2024)
Changed paths:
M qga/commands-posix.c
M qga/qapi-schema.json
Log Message:
-----------
qga: conditionalize schema for commands requiring fsfreeze
Rather than creating stubs for every command that just return
QERR_UNSUPPORTED, use 'if' conditions in the schema to fully
exclude generation of the filesystem freezing commands on POSIX
platforms lacking the required APIs.
The command will be rejected at QMP dispatch time instead,
avoiding reimplementing rejection by blocking the stub commands.
This changes the error message for affected commands from
{"class": "CommandNotFound", "desc": "Command FOO has been disabled"}
to
{"class": "CommandNotFound", "desc": "The command FOO has not been found"}
This has the additional benefit that the QGA protocol reference
now documents what conditions enable use of the command.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Message-ID: <20240712132459.3974109-14-berrange@redhat.com>
Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Commit: 21ca6854d8ef8020d605433773fceeecd10b11fd
https://github.com/qemu/qemu/commit/21ca6854d8ef8020d605433773fceeecd10b11fd
Author: Daniel P. Berrangé <berrange@redhat.com>
Date: 2024-07-19 (Fri, 19 Jul 2024)
Changed paths:
M qga/commands-posix.c
M qga/qapi-schema.json
Log Message:
-----------
qga: conditionalize schema for commands requiring fstrim
Rather than creating stubs for every command that just return
QERR_UNSUPPORTED, use 'if' conditions in the QAPI schema to
fully exclude generation of the filesystem trimming commands
on POSIX platforms lacking required APIs.
The command will be rejected at QMP dispatch time instead,
avoiding reimplementing rejection by blocking the stub commands.
This changes the error message for affected commands from
{"class": "CommandNotFound", "desc": "Command FOO has been disabled"}
to
{"class": "CommandNotFound", "desc": "The command FOO has not been found"}
This has the additional benefit that the QGA protocol reference
now documents what conditions enable use of the command.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Message-ID: <20240712132459.3974109-15-berrange@redhat.com>
Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Commit: adbe794a6ef7e8c52cec2dc3c8685f1a96507f24
https://github.com/qemu/qemu/commit/adbe794a6ef7e8c52cec2dc3c8685f1a96507f24
Author: Daniel P. Berrangé <berrange@redhat.com>
Date: 2024-07-19 (Fri, 19 Jul 2024)
Changed paths:
M qga/commands-linux.c
M qga/qapi-schema.json
Log Message:
-----------
qga: conditionalize schema for commands requiring libudev
Rather than creating stubs for every command that just return
QERR_UNSUPPORTED, use 'if' conditions in the schema to fully
exclude generation of the filesystem trimming commands on POSIX
platforms lacking required APIs.
The command will be rejected at QMP dispatch time instead,
avoiding reimplementing rejection by blocking the stub commands.
This changes the error message for affected commands from
{"class": "CommandNotFound", "desc": "Command FOO has been disabled"}
to
{"class": "CommandNotFound", "desc": "The command FOO has not been found"}
This has the additional benefit that the QGA protocol reference
now documents what conditions enable use of the command.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Message-ID: <20240712132459.3974109-16-berrange@redhat.com>
Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Commit: 2799f434a404276027f3e33debdcfae465ddac97
https://github.com/qemu/qemu/commit/2799f434a404276027f3e33debdcfae465ddac97
Author: Daniel P. Berrangé <berrange@redhat.com>
Date: 2024-07-19 (Fri, 19 Jul 2024)
Changed paths:
M qga/commands-posix.c
M qga/qapi-schema.json
Log Message:
-----------
qga: conditionalize schema for commands requiring utmpx
Rather than creating stubs for every command that just return
QERR_UNSUPPORTED, use 'if' conditions in the QAPI schema to
fully exclude generation of the get-users command on POSIX
platforms lacking required APIs.
The command will be rejected at QMP dispatch time instead,
avoiding reimplementing rejection by blocking the stub commands.
This changes the error message for affected commands from
{"class": "CommandNotFound", "desc": "Command FOO has been disabled"}
to
{"class": "CommandNotFound", "desc": "The command FOO has not been found"}
This has the additional benefit that the QGA protocol reference
now documents what conditions enable use of the command.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Message-ID: <20240712132459.3974109-17-berrange@redhat.com>
Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Commit: 4be55a4fce18de5ce660a0c2b0961a6333fd957f
https://github.com/qemu/qemu/commit/4be55a4fce18de5ce660a0c2b0961a6333fd957f
Author: Daniel P. Berrangé <berrange@redhat.com>
Date: 2024-07-19 (Fri, 19 Jul 2024)
Changed paths:
M meson.build
M qga/commands-posix.c
M qga/qapi-schema.json
Log Message:
-----------
qga: conditionalize schema for commands not supported on other UNIX
Rather than creating stubs for every command that just return
QERR_UNSUPPORTED, use 'if' conditions in the QAPI schema to
fully exclude generation of the commands on other UNIX.
The command will be rejected at QMP dispatch time instead,
avoiding reimplementing rejection by blocking the stub commands.
This changes the error message for affected commands from
{"class": "CommandNotFound", "desc": "Command FOO has been disabled"}
to
{"class": "CommandNotFound", "desc": "The command FOO has not been found"}
This has the additional benefit that the QGA protocol reference
now documents what conditions enable use of the command.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Message-ID: <20240712132459.3974109-18-berrange@redhat.com>
Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Commit: b81837f0d37ab1e1ee718d6a356e88089ec604b5
https://github.com/qemu/qemu/commit/b81837f0d37ab1e1ee718d6a356e88089ec604b5
Author: Daniel P. Berrangé <berrange@redhat.com>
Date: 2024-07-19 (Fri, 19 Jul 2024)
Changed paths:
M qga/commands-win32.c
M qga/main.c
Log Message:
-----------
qga: don't disable fsfreeze commands if vss_init fails
The fsfreeze commands are already written to report an error if
vss_init() fails. Reporting a more specific error message is more
helpful than a generic "command is disabled" message, which cannot
between an admin config decision and lack of platform support.
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20240712132459.3974109-19-berrange@redhat.com>
Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Commit: 3390a0de58426ae323f4ac63bef0d44234e4fad5
https://github.com/qemu/qemu/commit/3390a0de58426ae323f4ac63bef0d44234e4fad5
Author: Daniel P. Berrangé <berrange@redhat.com>
Date: 2024-07-19 (Fri, 19 Jul 2024)
Changed paths:
M qga/main.c
Log Message:
-----------
qga: move declare of QGAConfig struct to top of file
It is referenced by QGAState already, and it is clearer to declare all
data types at the top of the file, rather than have them mixed with
code later.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Message-ID: <20240712132459.3974109-20-berrange@redhat.com>
Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Commit: 8909fc17329a01dc0dc973486484cc73c8520754
https://github.com/qemu/qemu/commit/8909fc17329a01dc0dc973486484cc73c8520754
Author: Daniel P. Berrangé <berrange@redhat.com>
Date: 2024-07-19 (Fri, 19 Jul 2024)
Changed paths:
M qga/main.c
Log Message:
-----------
qga: remove pointless 'blockrpcs_key' variable
This variable was used to support back compat for the old config
file key name, and became redundant after the following change:
commit a7a2d636ae4549ef0551134d4bf8e084a14431c4
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: Thu May 30 08:36:43 2024 +0200
qga: Remove deprecated 'blacklist' argument / config key
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Message-ID: <20240712132459.3974109-21-berrange@redhat.com>
Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Commit: f8bf2347ed6036adf195202fa55c2cb587004679
https://github.com/qemu/qemu/commit/f8bf2347ed6036adf195202fa55c2cb587004679
Author: Daniel P. Berrangé <berrange@redhat.com>
Date: 2024-07-19 (Fri, 19 Jul 2024)
Changed paths:
M docs/interop/qemu-ga.rst
M qga/main.c
Log Message:
-----------
qga: allow configuration file path via the cli
Allowing the user to set the QGA_CONF environment variable to change
the default configuration file path is very unusual practice, made
more obscure since this ability is not documented.
This introduces the more normal '-c PATH' / '--config=PATH' command
line argument approach. This requires that we parse the comamnd line
twice, since we want the command line arguments to take priority over
the configuration file settings in general.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Message-ID: <20240712132459.3974109-22-berrange@redhat.com>
Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Commit: 2e3b166c41e20eba7e74d9a9203a663cc455bc49
https://github.com/qemu/qemu/commit/2e3b166c41e20eba7e74d9a9203a663cc455bc49
Author: Daniel P. Berrangé <berrange@redhat.com>
Date: 2024-07-19 (Fri, 19 Jul 2024)
Changed paths:
M docs/interop/qemu-ga.rst
M qga/commands-posix.c
M qga/commands-win32.c
M qga/main.c
Log Message:
-----------
qga: centralize logic for disabling/enabling commands
It is confusing having many different pieces of code enabling and
disabling commands, and it is not clear that they all have the same
semantics, especially wrt prioritization of the block/allow lists.
The code attempted to prevent the user from setting both the block
and allow lists concurrently, however, the logic was flawed as it
checked settings in the configuration file separately from the
command line arguments. Thus it was possible to set a block list
in the config file and an allow list via a command line argument.
The --dump-conf option also creates a configuration file with both
keys present, even if unset, which means it is creating a config
that cannot actually be loaded again.
Centralizing the code in a single method "ga_apply_command_filters"
will provide a strong guarantee of consistency and clarify the
intended behaviour. With this there is no compelling technical
reason to prevent concurrent setting of both the allow and block
lists, so this flawed restriction is removed.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Message-ID: <20240712132459.3974109-23-berrange@redhat.com>
Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Commit: 1d523869d71aa5e4e17f652c04628ee8432bb8d2
https://github.com/qemu/qemu/commit/1d523869d71aa5e4e17f652c04628ee8432bb8d2
Author: Zhao Liu <zhao1.liu@intel.com>
Date: 2024-07-19 (Fri, 19 Jul 2024)
Changed paths:
M qga/commands-posix.c
Log Message:
-----------
qga/commands-posix: Make ga_wait_child() return boolean
Make ga_wait_child() return boolean and check the returned boolean
in ga_run_command() instead of dereferencing @errp.
Cc: Michael Roth <michael.roth@amd.com>
Cc: Konstantin Kostiuk <kkostiuk@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Message-ID: <20240716162351.270095-1-zhao1.liu@intel.com>
Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Commit: ce22616181c34d8a9755e8db1b8c27b6f8cedb74
https://github.com/qemu/qemu/commit/ce22616181c34d8a9755e8db1b8c27b6f8cedb74
Author: Thomas Lamprecht <t.lamprecht@proxmox.com>
Date: 2024-07-19 (Fri, 19 Jul 2024)
Changed paths:
M docs/interop/qemu-ga.rst
Log Message:
-----------
guest-agent: document allow-rpcs in config file section
While the `allow-rpcs` option is documented in the CLI options
section, it was missing in the section about the configuration file
syntax.
And while it's mentioned that "the list of keys follows the command line
options", having `block-rpcs` there but not `allow-rpcs` seems like
being a potential source of confusion; and as it's cheap to add let's
just do so.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Message-ID: <20240718140407.444160-1-t.lamprecht@proxmox.com>
Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Commit: 24d12dfc5abb3b4ac2506f22c3fd0cda40a6977d
https://github.com/qemu/qemu/commit/24d12dfc5abb3b4ac2506f22c3fd0cda40a6977d
Author: Dehan Meng <demeng@redhat.com>
Date: 2024-07-22 (Mon, 22 Jul 2024)
Changed paths:
M qga/commands-linux.c
M qga/qapi-schema.json
Log Message:
-----------
qga/linux: Add new api 'guest-network-get-route'
The Route information of the Linux VM needs to be used
by administrators and users when debugging network problems
and troubleshooting.
Signed-off-by: Dehan Meng <demeng@redhat.com>
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Message-ID: <20240613092802.346246-2-demeng@redhat.com>
Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Commit: 5d817b06f32bd2353b8482ffa009e1fac6e2ff90
https://github.com/qemu/qemu/commit/5d817b06f32bd2353b8482ffa009e1fac6e2ff90
Author: Richard Henderson <richard.henderson@linaro.org>
Date: 2024-07-23 (Tue, 23 Jul 2024)
Changed paths:
M docs/interop/qemu-ga.rst
M meson.build
M qga/commands-bsd.c
M qga/commands-common.h
M qga/commands-linux.c
M qga/commands-posix.c
M qga/commands-win32.c
M qga/main.c
M qga/qapi-schema.json
Log Message:
-----------
Merge tag 'qga-pull-2024-07-22' of https://github.com/kostyanf14/qemu into
staging
qga-pull-2024-07-22
# -----BEGIN PGP SIGNATURE-----
#
# iQIzBAABCAAdFiEEwsLBCepDxjwUI+uE711egWG6hOcFAmaeAo0ACgkQ711egWG6
# hOftWQ/9HGQZAKOpUnEPa5klFseSfjzRBagg2ma0Q4oS/+/wVIBPJvbTf6fobhRH
# xwLoZwD/0Qt+YQu4K6tqGObxQRW4R+LnyH5KC1HL78W+ARYJqa0lhoez259MNatG
# EX00SvvCD/E1AuGBCL6CjSXwNbGngTW92QGJ7BcCGdTb93DdHr4EVjY7yPI77dcN
# anOGaeZEuFrRMjWJyhKssVhqnpgLcY9nxZ9NOrjVLITxghubkYNJw/g9QXgwM4rj
# y3WJ5RanAythtj7TznMHO0AaQdaHXI1YGZD8PEYykP4UBmMjSnaKjiIGz6xfrYZO
# VYszR74J+Y/pAKQ4SzdOyWOUL/2B1nuaS8raqhp4zyEwhHeF97ND+TnWDjYibtHa
# AGC305BdQ8FP2tbdSOquTbjVXodYb8hnJMmgAbBYE0zlnQ/jipoBX+cbEFClO7zl
# Ek8X1GRMJ6t5+iTltYsnhAZG5iR6f8bE9VzChPcekaB3O1tPohiLfPazX3KX7Xtr
# gC1HMN3HOCHSTsjvAIDB+VdU+0Lmxvl2zpY/kcyTIadjFxSnx9+5wY9myw+fA4nW
# CInyVpjwNvHs6RVUWncWF2mgdJr9VGzQRtFxw0RL/gAgpNhRWjLsgDc6I/cOqPU+
# rjhG/UMQhrpUvXu7H2XqHYBCGnXyrp8DS49IU8z/ukKPDy0Th1Q=
# =Ci3y
# -----END PGP SIGNATURE-----
# gpg: Signature made Mon 22 Jul 2024 04:56:13 PM AEST
# gpg: using RSA key C2C2C109EA43C63C1423EB84EF5D5E8161BA84E7
# gpg: Good signature from "Kostiantyn Kostiuk (Upstream PR sign)
<kkostiuk@redhat.com>" [unknown]
# gpg: WARNING: This key is not certified with a trusted signature!
# gpg: There is no indication that the signature belongs to the owner.
# Primary key fingerprint: C2C2 C109 EA43 C63C 1423 EB84 EF5D 5E81 61BA 84E7
* tag 'qga-pull-2024-07-22' of https://github.com/kostyanf14/qemu: (25 commits)
qga/linux: Add new api 'guest-network-get-route'
guest-agent: document allow-rpcs in config file section
qga/commands-posix: Make ga_wait_child() return boolean
qga: centralize logic for disabling/enabling commands
qga: allow configuration file path via the cli
qga: remove pointless 'blockrpcs_key' variable
qga: move declare of QGAConfig struct to top of file
qga: don't disable fsfreeze commands if vss_init fails
qga: conditionalize schema for commands not supported on other UNIX
qga: conditionalize schema for commands requiring utmpx
qga: conditionalize schema for commands requiring libudev
qga: conditionalize schema for commands requiring fstrim
qga: conditionalize schema for commands requiring fsfreeze
qga: conditionalize schema for commands only supported on Windows
qga: conditionalize schema for commands requiring linux/win32
qga: conditionalize schema for commands requiring getifaddrs
qga: conditionalize schema for commands unsupported on non-Linux POSIX
qga: conditionalize schema for commands unsupported on Windows
qga: move CONFIG_FSFREEZE/TRIM to be meson defined options
qga: move linux memory block command impls to commands-linux.c
...
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Compare: https://github.com/qemu/qemu/compare/2d5b4ea7f697...5d817b06f32b
To unsubscribe from these emails, change your notification settings at
https://github.com/qemu/qemu/settings/notifications
- [Qemu-commits] [qemu/qemu] 661813: qga: drop blocking of guest-get-memory-block-size ...,
Richard Henderson <=