[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [MIPS] Use conditional traps for BUG_ON on MIPS II and
From: |
Thiemo Seufer |
Subject: |
[Qemu-devel] Re: [MIPS] Use conditional traps for BUG_ON on MIPS II and better. |
Date: |
Sat, 16 Dec 2006 17:11:43 +0000 |
User-agent: |
Mutt/1.5.13 (2006-08-11) |
Atsushi Nemoto wrote:
> On Sun, 3 Dec 2006 21:35:18 +0000, Ralf Baechle <address@hidden> wrote:
> > > It seems this commit break QEMU kernel ... or QEMU can not interpret
> > > the TNE instruction correctly?
> >
> > Thiemo says that's indeed a possibility. Probably that feature has not
> > been well tested in qemu.
>
> I found the bug. "Trap If XXX" instructions are translated as it was
> "Trap If XXX Immediate".
>
> Index: target-mips/translate.c
> ===================================================================
> RCS file: /sources/qemu/qemu/target-mips/translate.c,v
> retrieving revision 1.27
> diff -u -r1.27 translate.c
> --- target-mips/translate.c 10 Dec 2006 22:08:10 -0000 1.27
> +++ target-mips/translate.c 15 Dec 2006 16:16:07 -0000
> @@ -1276,6 +1276,7 @@
> GEN_LOAD_REG_TN(T1, rt);
> cond = 1;
> }
> + break;
> case OPC_TEQI:
> case OPC_TGEI:
> case OPC_TGEIU:
Thanks, committed.
Thiemo
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-devel] Re: [MIPS] Use conditional traps for BUG_ON on MIPS II and better.,
Thiemo Seufer <=