[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Patch: dyngen-exec.h for OpenBSD
From: |
Thiemo Seufer |
Subject: |
Re: [Qemu-devel] Patch: dyngen-exec.h for OpenBSD |
Date: |
Mon, 2 Apr 2007 17:08:39 +0100 |
User-agent: |
Mutt/1.5.13 (2006-08-11) |
M. Warner Losh wrote:
> In message: <address@hidden>
> Thiemo Seufer <address@hidden> writes:
> : I made that "#ifdef _BSD" based on the assumption it is ok for all
> : BSD variants, including Darwin.
>
> _BSD isn't defined on all variants of BSD. sys/param.h defines BSD to
> be 199506 on all BSD systems (at least all of them derived from 4.4BSD
> lite). sys/param.h also defines BSD4_3 and BSD4_4. FreeBSD defines
> __FreeBSD__ in the compiler, NetBSD defined __NetBSD__, OpenBSD
> defines __OpenBSD__. I'm unsure what darwin/osx define.
>
> so unless I missed a change elsewhere in the build system to define
> _BSD, this change needs some more thought.
It is already used in other files. The define in qemu comes from the
configure script via config.h, which might be a bug.
Thiemo