[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Update i440FX/PIIX3 emulation
From: |
Michael Hanselmann |
Subject: |
Re: [Qemu-devel] [PATCH] Update i440FX/PIIX3 emulation |
Date: |
Wed, 31 Oct 2007 19:19:32 +0100 |
User-agent: |
Mutt/1.5.16 (2007-06-09) |
Hi Avi
On Wed, Oct 31, 2007 at 03:17:04PM +0200, Avi Kivity wrote:
>> --- bios/acpi-dsdt.dsl 28 Sep 2006 18:56:20 -0000 1.1
>> +++ bios/acpi-dsdt.dsl 30 Oct 2007 23:52:22 -0000
>> @@ -369,7 +369,7 @@ DefinitionBlock (
>> Method (_STA, 0, NotSerialized)
>> {
>> Store (0x0B, Local0)
>> - If (And (0x80, PRQ0, Local1))
>> + If (And (0x80, PRQ0, Local0))
>> {
>> Store (0x09, Local0)
>> }
> Can you explain this?
>
> The original code seems to return either 0xb (present, enabled, functional)
> or 0x9 (present, functional). The new code seems to return either 0x9
> (present, functional) or 0 (if PRQ0 had its seventh bit clear).
>
> Am I reading the code incorrectly?
It looks like you're correct. Here's the same function from a HP
Pavilion laptop:
Method (_STA, 0, NotSerialized)
{
If (And (PIRH, 0x80))
{
Return (0x09)
}
Return (0x0B)
}
Basically this means I have to go back to debug this stuff.
Sorry for the false alarm,
Michael
--
http://hansmi.ch/