[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: [kvm-devel] [PATCH 1 of 3] export SMBIOS/DMI tables
From: |
Ryan Harper |
Subject: |
Re: [Qemu-devel] Re: [kvm-devel] [PATCH 1 of 3] export SMBIOS/DMI tables to PC machines |
Date: |
Fri, 7 Dec 2007 15:13:18 -0600 |
User-agent: |
Mutt/1.5.6+20040907i |
* Anthony Liguori <address@hidden> [2007-12-07 15:07]:
> Ryan Harper wrote:
> >* Anthony Liguori <address@hidden> [2007-12-07 14:49]:
> >
> >>>+
> >>>+CPUState *first_cpu;
> >>>
> >>>
> >>This should probably be static.
> >>
> >
> >doh, should be extern actually since it's defined elsewhere.
> >
>
> Perhaps you want cpu_single_env instead of first_cpu?
I wasn't quite sure given the comments surrounding its declaration:
from exec.c:
CPUState *first_cpu;
/* current CPU in the current thread. It is only valid inside
cpu_exec() */
CPUState *cpu_single_env;
--
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
(512) 838-9253 T/L: 678-9253
address@hidden