[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/6] virtio network driver
From: |
Paul Brook |
Subject: |
Re: [Qemu-devel] [PATCH 4/6] virtio network driver |
Date: |
Sun, 30 Mar 2008 10:27:07 +0000 |
User-agent: |
KMail/1.9.9 |
On Saturday 29 March 2008, Anthony Liguori wrote:
> + if ((elem = virtqueue_pop(n->rx_vq)) == NULL) {
> + /* wait until the guest adds some rx bufs */
> + n->can_receive = 0;
> + return;
> + }
Setting can_receive to zero *after* dropping a packet is a bit late.
Not a fatal flaw, but it does make can_receive fairly useless. The whole point
of can_receive is to workaround lack of proper TCP rate control in the slirp
code.
Paul
- Re: [kvm-devel] [Qemu-devel] [PATCH 2/6] PCI DMA API, (continued)
Re: [Qemu-devel] [PATCH 2/6] PCI DMA API, Paul Brook, 2008/03/30
[Qemu-devel] Re: [kvm-devel] [PATCH 2/6] PCI DMA API, Avi Kivity, 2008/03/30
[Qemu-devel] [PATCH 4/6] virtio network driver, Anthony Liguori, 2008/03/29
- Re: [Qemu-devel] [PATCH 4/6] virtio network driver,
Paul Brook <=