Re: [Qemu-devel] [PATCH 03/14] QEMU: Fill in PCI subsystem vendor id for e1000

[Amit Shah]

On Tuesday 27 May 2008 00:06:13 M. Warner Losh wrote:
> Picking a random one to reply to:
>
> In message: <address@hidden>
>
>             Amit Shah <address@hidden> writes:
> : The subsystem vendor ID shouldn't be 0x0 or 0xffff according
> : to the PCI spec
>
> Old versions of the spec allowed for these values.  Many older PCI
> devices have 0xffff as their subvendor ID.  This is especially true
> for video cards...

This is based on version 2.3 of the spec.

> I'd be cautious in applying these patches, since QEMU tends to emulate
> very old devices in some cases...

I would suggest applying the patches which have no objection and then 
reverting the ones which might cause such problems. We won't know who's using 
what unless this is done. That's the precise reason I've split them into so 
many patches.

Amit.