Re: [Qemu-devel] [RESEND #3][PATCH] Report unmapped addresses in memory_dump

[Anthony Liguori]

Jan Kiszka wrote:
> Instead of dumping incorrect (ie. previously read) data, report the
> invalid virtual address to the user.
>   

Applied.  Thanks.

Sorry it took three resends.

Regards,

Anthony Liguori

> Signed-off-by: Jan Kiszka <address@hidden>
> ---
>  monitor.c |    5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> Index: b/monitor.c
> ===================================================================
> --- a/monitor.c
> +++ b/monitor.c
> @@ -594,7 +594,10 @@ static void memory_dump(int count, int f
>              env = mon_get_cpu();
>              if (!env)
>                  break;
> -            cpu_memory_rw_debug(env, addr, buf, l, 0);
> +            if (cpu_memory_rw_debug(env, addr, buf, l, 0) < 0) {
> +                term_printf(" Cannot access memory\n");
> +                break;
> +            }
>          }
>          i = 0;
>          while (i < l) {
>
>
>