Re: [Qemu-devel] [PATCH] add futimesat syscall

[Kirill A. Shutemov]

On Thu, Sep 18, 2008 at 12:08:21PM +0300, Riku Voipio wrote:
> On Thu, Sep 18, 2008 at 09:23:20AM +0200, Laurent Desnogues wrote:
> > On Thu, Sep 18, 2008 at 8:30 AM, Riku Voipio <address@hidden> wrote:
> > > On Thu, Sep 18, 2008 at 01:54:21AM +0200, andrzej zaborowski wrote:
> 
> > >> http://lists.gnu.org/archive/html/qemu-devel/2008-09/msg00439.html ,
> > >> it looks cleaner to me.
> 
> > > Kirill's patch looks good to me.
> 
> > There's a functional difference between Kirill's patch and yours:
> 
> > Kirill +            ret = get_errno(futimesat(arg1, p, tvp));
> > you   +                ret = get_errno(sys_futimesat(arg1, path(p), tv));
> 
> The sbox patch defines sys_futimesat earlier in the file, presumably to
> deal with supporting a stone-age version of libc/kernel headers.

I don't think that it's great idea. If libc/kernel headers doesn't provide
the syscall we shouldn't implement them. The exception is syscalls without
libc's wrapper. Like gettid(2).

> path() is related to interp_prefix. The old utimes handlers don't use
> path() either, and it's unlikely that any library-loading routine uses
> futimes(). Thus, I believe Kirill's version is more correct.

I have written futimeat based on utimes(). If utimes() emulation work 
properly with interp_prefix != "/", futimesat() also will. But I have
never test it with interp_prefix != "/"

-- 
Regards,  Kirill A. Shutemov
 + Belarus, Minsk
 + ALT Linux Team, http://www.altlinux.com/

signature.asc
Description: Digital signature