[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Add readahead syscall
|
From: |
Kirill A. Shutemov |
|
Subject: |
Re: [Qemu-devel] [PATCH] Add readahead syscall |
|
Date: |
Sun, 21 Sep 2008 17:01:09 +0300 |
|
User-agent: |
Mutt/1.5.18 (2008-05-29) |
On Sun, Sep 21, 2008 at 02:03:16PM +0100, Paul Brook wrote:
> > #ifdef TARGET_NR_readahead
> > case TARGET_NR_readahead:
> > - goto unimplemented;
> > + ret = get_errno(readahead(arg1, arg2, arg3));
> > + break;
>
> This is wrong on 32-bit targets, and especially wrong on ARM where there are
> two variants.
Two variants?
$ git grep readahead arch/arm/include/asm/unistd.h
arch/arm/include/asm/unistd.h:#define __NR_readahead (__NR_SYSCALL_BASE+225)
--
Regards, Kirill A. Shutemov
+ Belarus, Minsk
+ ALT Linux Team, http://www.altlinux.com/
signature.asc
Description: Digital signature