Re: [Qemu-devel] [PATCH][Resend] IDE: Return zero when reading error register with slave selected

[Anthony Liguori]

Justin Chevrier wrote:
> Original text below. Patch updated against head.
>
> During hardware detection Openserver issues commands to slaves on both primary 
> and secondary ports. We already return a zero for the status register in this 
> situation but after reading the status register the Openserver installer 
> proceeds to check the value of the error register. Currently we return the 
> existing value in the register. This confuses the installer and it tries to 
> access the slave units later on. When the command that gets issued later gets 
> ignored the installer freezes. The patch below returns zero when reading the 
> error register if a slave unit is selected. Openserver can now successfully be 
> installed using the emulated IDE hard drive.
>
> Changelog:
>
> Return zero when reading error register with slave selected
>
> Signed-off-by: Justin Chevrier <address@hidden>
>   

Applied.  Thanks for resending.

Regards,

Anthony Liguori

> --- hw/ide.c    (revision 6244)
> +++ hw/ide.c    (working copy)
> @@ -2467,7 +2467,8 @@
>          ret = 0xff;
>          break;
>      case 1:
> -        if (!ide_if[0].bs && !ide_if[1].bs)
> +        if ((!ide_if[0].bs && !ide_if[1].bs) ||
> +            (s != ide_if && !s->bs))
>              ret = 0;
>          else if (!hob)
>              ret = s->error;
>
>
>
>       
>
>
>