[Qemu-devel] Re: [PATCH 1/5] Add target memory mapping API

[Anthony Liguori]

Avi Kivity wrote:
> Anthony Liguori wrote:
> > > +        if ((pd & ~TARGET_PAGE_MASK) != IO_MEM_RAM) {
> > > +            if (done || bounce.buffer) {
> > > +                break;
> > > +            }
> > > +            bounce.buffer = qemu_memalign(TARGET_PAGE_SIZE, 
> > > TARGET_PAGE_SIZE);
> > > +            bounce.addr = addr;
> > > +            bounce.len = l;
> > >   
> >
> > I like the bouncing approach.  Namely, that it never bounces more 
> > than a page at a time.  I think that's clever.
>
> I tried to make it as stupid as possible.  Looks like I failed.

Or your version of stupid is my version of clever :-)

Regards,

Anthony Liguori