Re: [Qemu-devel] [PATCH] Fix cpuid KVM crash on i386

[Anthony Liguori]

Lubomir Rintel wrote:
> Cpuid should return into vec, not overwrite past address in count.
> Changeset 6565 broke this.
>   

Applied to both stable and trunk.  Thanks.

Regards,

Anthony Liguori

> Signed-off-by: Lubomir Rintel <address@hidden>
>
> Index: target-i386/helper.c
> ===================================================================
> --- target-i386/helper.c        (revision 6676)
> +++ target-i386/helper.c        (working copy)
> @@ -1418,10 +1418,10 @@
>  #else
>      asm volatile("pusha \n\t"
>                   "cpuid \n\t"
> -                 "mov %%eax, 0(%1) \n\t"
> -                 "mov %%ebx, 4(%1) \n\t"
> -                 "mov %%ecx, 8(%1) \n\t"
> -                 "mov %%edx, 12(%1) \n\t"
> +                 "mov %%eax, 0(%2) \n\t"
> +                 "mov %%ebx, 4(%2) \n\t"
> +                 "mov %%ecx, 8(%2) \n\t"
> +                 "mov %%edx, 12(%2) \n\t"
>                   "popa"
>                   : : "a"(function), "c"(count), "S"(vec)
>                   : "memory", "cc");
>
>
>
>
>
>