[Qemu-devel] Re: [PATCH] create kvm-shared-all.c and kvm-shared.h

[Glauber Costa]

On Tue, Jun 09, 2009 at 06:17:25PM +0200, Jan Kiszka wrote:
> Glauber Costa wrote:
> > Following a suggestion given by Jan, the idea here is to
> > move shared pieces between qemu and qemu-kvm.git into a common
> > file, so we can do sharing while avoid clashes.
> > 
> > In the future, this files should disappear.
> > 
> 
> OK for the header - but why do we have to push the ioctl services into a
> separate module? Will all functions qemu-kvm start to use from upstream
> have to be pushed around? Or what is special about the ioctls?
> 
> I rather think qemu-kvm should build kvm-all.c and #ifdef out those
> parts which collide with its own implementation. Moreover, when we morph
> qemu-kvm services for upstream, this could already happen where they
> shall once be located: in kvm-all.c or target-*/kvm.c.
I also think qemu-kvm should build kvm-all.c. But right now, it is so full
of conflicts, that it would be impossible. My go with the module, is, whenever
we move all the code in kvm-all.c away, it should mean it is safe to go back to
it: qemu-kvm will be granted not to conflict with it.