[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC] Enable Werrror by default
From: |
Mark McLoughlin |
Subject: |
Re: [Qemu-devel] [RFC] Enable Werrror by default |
Date: |
Thu, 11 Jun 2009 19:38:45 +0100 |
On Thu, 2009-06-11 at 13:30 -0500, Anthony Liguori wrote:
> How about the following? It currently only enables werror for Linux
> hosts and git builds.
>
...
> +# Consult white-list to determine whether to enable werror
> +# by default. Only enable by default for git builds
> +if test -z "$werror" ; then
> + z_version=`cut -f3 -d. $source_path/VERSION`
> + if test "$z_version" = "50" -a \
Looks good, except this will enable it in kvm-XX releases, and not in
future stable branches.
How about just 'test -d $source_path/.git/' ?
Cheers,
Mark.
- [Qemu-devel] [RFC] Enable Werrror by default, Paul Brook, 2009/06/11
- Re: [Qemu-devel] [RFC] Enable Werrror by default, Tristan Gingold, 2009/06/11
- Re: [Qemu-devel] [RFC] Enable Werrror by default, Anthony Liguori, 2009/06/11
- Re: [Qemu-devel] [RFC] Enable Werrror by default, Mark McLoughlin, 2009/06/11
- Re: [Qemu-devel] [RFC] Enable Werrror by default, Christoph Egger, 2009/06/11
- Re: [Qemu-devel] [RFC] Enable Werrror by default, Paul Brook, 2009/06/11
- Re: [Qemu-devel] [RFC] Enable Werrror by default, Richard W.M. Jones, 2009/06/11
- Re: [Qemu-devel] [RFC] Enable Werrror by default, Anthony Liguori, 2009/06/11
- Re: [Qemu-devel] [RFC] Enable Werrror by default, Paul Brook, 2009/06/11
- Re: [Qemu-devel] [RFC] Enable Werrror by default, David Turner, 2009/06/11