|
From: | Anthony Liguori |
Subject: | Re: [Qemu-devel] [PATCH] avoid compilation warning/errors on up to date compilers |
Date: | Tue, 16 Jun 2009 15:56:43 -0500 |
User-agent: | Thunderbird 2.0.0.21 (X11/20090320) |
Stuart Brady wrote:
On Tue, Jun 16, 2009 at 06:03:43PM +0300, Riku Voipio wrote:Which tree against did you make these changes? the qemu-ndb.c bit didn't apply against HEAD. Also, there are some whitespace/tab issues. See the CODING_STYLE doc. Functionally I can verify it removes compiler warnings when using a modenr glibc (2.9).Unfortunately, some of the changes don't look right.
I think adding -D_FORTIFY_SOURCE=1 to CFLAGS is probably a better fix than adding broken error handling everywhere.
Regards, Anthony Liguori
[Prev in Thread] | Current Thread | [Next in Thread] |