qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] bios: Fix multiple calls into smbios_load_exter


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH] bios: Fix multiple calls into smbios_load_external()
Date: Wed, 17 Jun 2009 17:30:24 +0200
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.3 (gnu/linux)

Alex Williamson <address@hidden> writes:

> We're marking the used entry bitmap in smbios_load_external() for each
> type we check, regardless of whether we loaded anything.  This makes
> subsequent calls behave as if we've already loaded the tables from qemu
> and can result in missing tables (ex. multiple type4 entries on an SMP
> guest).  Only mark the bitmap if we actually load something.
>
> Signed-off-by: Alex Williamson <address@hidden>
> --

For what it's worth, I got bitten by this bug (one of two CPUs missing
from dmidecode), and the patch fixes it.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]