Re: [Qemu-devel] [PATCH] allow for name property in pci devices.

[Gerd Hoffmann]

On 06/18/09 09:33, Mark McLoughlin wrote:
> > -    pci_dev = do_pci_register_device(pci_dev, bus, "FIXME", devfn,
> > +    name = qdev_get_prop_ptr(qdev, "name");
> > +
> > +    pci_dev = do_pci_register_device(pci_dev, bus, name, devfn,
> >                                        NULL, NULL);//FIXME:config_read, 
> > config_write);
>
> Why not just use base->name here?

+1

While we are at it:  Do we need the name field in PCIDevice the first 
place then?  Well, maybe better keep it until all pci devices are moved 
over to qdev.

cheers,
  Gerd