Re: [Qemu-devel] [PATCH v4 01/12] fix qemu_alloc/qemu_free for block subsystem

[Kevin Wolf]

Jean-Christophe DUBOIS schrieb:
> From: Jean-Christophe Dubois <address@hidden(none)>
> 
> Signed-off-by: Jean-Christophe DUBOIS <address@hidden>
> ---
>  block/cloop.c |    6 +++---
>  block/dmg.c   |   14 +++++++-------
>  block/vvfat.c |   36 ++++++++++++++++++------------------
>  3 files changed, 28 insertions(+), 28 deletions(-)

[...]

> 
> diff --git a/block/cloop.c b/block/cloop.c
> index 06c687e..709b7d6 100644
> --- a/block/cloop.c
> +++ b/block/cloop.c
> @@ -148,9 +148,9 @@ static void cloop_close(BlockDriverState *bs)
>      BDRVCloopState *s = bs->opaque;
>      close(s->fd);
>      if(s->n_blocks>0)
> -     free(s->offsets);
> -    free(s->compressed_block);
> -    free(s->uncompressed_block);
> +     qemu_free(s->offsets);
> +    qemu_free(s->compressed_block);
> +    qemu_free(s->uncompressed_block);
>      inflateEnd(&s->zstream);
>  }
>  
> diff --git a/block/dmg.c b/block/dmg.c
> index 262560f..14ebe59 100644
> --- a/block/dmg.c
> +++ b/block/dmg.c
> @@ -273,14 +273,14 @@ static void dmg_close(BlockDriverState *bs)
>      BDRVDMGState *s = bs->opaque;
>      close(s->fd);
>      if(s->n_chunks>0) {
> -     free(s->types);
> -     free(s->offsets);
> -     free(s->lengths);
> -     free(s->sectors);
> -     free(s->sectorcounts);
> +     qemu_free(s->types);
> +     qemu_free(s->offsets);
> +     qemu_free(s->lengths);
> +     qemu_free(s->sectors);
> +     qemu_free(s->sectorcounts);
>      }

Just one small thing I noticed: This indentation looks like tabs. While
you're changing these lines anyway, you could use the chance to correct
the style to use spaces instead. I guess you could do this all over the
patch series.

But there is no need to resend the series if you don't need to change
anything else, of course.

Kevin