|
From: | Anthony Liguori |
Subject: | Re: [Qemu-devel] [PATCH] replace O_SYNC with O_FSYNC |
Date: | Sat, 20 Jun 2009 18:37:25 -0500 |
User-agent: | Thunderbird 2.0.0.21 (X11/20090320) |
Jamie Lokier wrote:
If O_FSYNC and O_SYNC do the same thing, and O_SYNC is used anywhere, there's no harm in this for portability: #if !defined(O_SYNC) && defined(O_FSYNC) #define O_SYNC O_FSYNC #endif The patch assumes O_FSYNC is defined if O_SYNC isn't, which is wrong.
For what this patch is, it really isn't that important IMHO. This is just a work around for a broken platform. Regards, Anthony Liguori
[Prev in Thread] | Current Thread | [Next in Thread] |