Re: [Qemu-devel] [PATCH] cocoa.m issues fixed

[Andreas Färber]

Am 21.06.2009 um 03:19 schrieb G 3:

> This patch allows the file cocoa.m to compile under Mac OS 10.3.   
> MAC_OS_X_VERSION_10_4 isn't defined under Mac OS 10.3. The #define  
> will define it. The method cStringUsingEncoding isn't defined under  
> Mac OS 10.3, so I used a similar function that does work.
>
> Signed-off-by: programmingkid  <address@hidden>
> --- cocoa.m     Wed May 20 16:46:58 2009
> +++ cocoa (edited).m    Sat Jun 20 20:57:41 2009

> @@ -55,6 +62,8 @@
> } QEMUScreen;
>
> int qemu_main(int argc, char **argv); // main defined in qemu/vl.c
> +int cocoa_keycode_to_qemu(int keycode);
> +

This seems unrelated. I believe you're trying to suppress a warning  
I've been seeing on 10.5 as well - if so, please provide that as a  
separate patch with appropriate description.

> NSWindow *normalWindow;
> id cocoaView;
> static DisplayChangeListener *dcl;
> @@ -783,8 +792,8 @@
>     if(returnCode == NSCancelButton) {
>         exit(0);
>     } else if(returnCode == NSOKButton) {
> -        char *bin = "qemu";
> -        char *img = (char*)[ [ sheet filename ]  
> cStringUsingEncoding:NSASCIIStringEncoding];
> +        char bin[5] = "qemu";

What warning/error does this solve?

> +        char *img = (char*)[ [ sheet filename ] cString];
>
>         char **argv = (char**)malloc( sizeof(char*)*3 );

Andreas