|
From: | Avi Kivity |
Subject: | Re: [Qemu-devel] [PATCH] Implement PC port80 debug register. |
Date: | Mon, 29 Jun 2009 21:43:12 +0300 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Thunderbird/3.0b2 |
On 06/29/2009 09:39 PM, Anthony Liguori wrote:
Avi Kivity wrote:I still think the read/write port route would * better emulate systems, * be more flexible (allowing software the option to read it), * and, be easier to implement :)But, I think the most important part is to make the data accessible somehow. So, the monitor access method would work fine as well.I don't object to read/write access.If there's read and write access, it needs to be part of the savevm state.
That's true even if it's write only, as long as it is observable somehow (in our case, from the monitor).
Is it per-cpu?
No, it's a normal pci/isa card.
I'd lean toward write-only unless there was a compelling reason to make it read/write.
I can't say there's a compelling reason for that. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.
[Prev in Thread] | Current Thread | [Next in Thread] |