|
From: | Gerd Hoffmann |
Subject: | Re: [Qemu-devel] [RFC PATCH] qdev: add -pcidevice command line option. |
Date: | Tue, 30 Jun 2009 17:41:21 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Lightning/1.0pre Thunderbird/3.0b2 |
Hi,
-pcidevice can be useful now, for devices converted to qdev, but it doesn't fully work for certain incomplete conversions.
For incomplete conversions it may cause all sorts of strange effects, so Paul has a point here IMHO.
While that's inacceptable for a release, is it really so horrible as a transient step now? Besides, we can easily flag incompletely converted devices, and make -pcidevice not touch them.
While thinking about that: We probably need a flag in DeviceInfo anyway to tag devices which are not supposed to be added via -pcidevice (soon to be -device). It doesn't make much sense to allow the user adding - say - interrupt controllers via command line.
Such a flag could also be used to prevent incompletely converted drivers to be used via -device.
cheers, Gerd
[Prev in Thread] | Current Thread | [Next in Thread] |