qemu-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [RfC PATCH 1/3] net: macaddr tweaks.

From: Paolo Bonzini
Subject: [Qemu-devel] Re: [RfC PATCH 1/3] net: macaddr tweaks.
Date: Wed, 30 Sep 2009 13:57:04 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.1) Gecko/20090814 Fedora/3.0-2.6.b3.fc11 Lightning/1.0pre Thunderbird/3.0b3 


+void qemu_macaddr_default_if_unset(macaddr_t macaddr)
+{
+    macaddr_t zero = { 0,0,0,0,0,0 };


Very minor since this is not at all a hot path, but please make it just

  static macaddr_t zero;

since otherwise it would be initialized on the stack at run time.

Paolo
reply via email to
[Prev in Thread] Current Thread [Next in Thread]