Re: [Qemu-devel] [PATCH 0/4] megaraid_sas HBA emulation

[Gerd Hoffmann]

On 10/29/09 05:37, Christoph Hellwig wrote:

>   - try to create generic scsi device/request structures that the hba
>     driver can access, and which contain additional private data for
>     scsi-disk/generic.  Information in the generic one would include
>     the information about the data transfer, the tag and the command
>     block.

Agreed.  For scsi device this did already happen as part of the 
qdev-ification work.  It certainly makes sense to do that for scsi 
requests too.  May also allow to kill some code duplication in 
scsi-disk.c and scsi-generic.c

>   - try to get rid of the tag indexing stuff by just using a pointer to
>     the generic scsi request in the hba drivers.  That should get rid
>     of a lot of useless list searching.

Indeed.

cheers,
  Gerd