[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: commit rules for common git tree
From: |
Aurelien Jarno |
Subject: |
[Qemu-devel] Re: commit rules for common git tree |
Date: |
Sun, 27 Dec 2009 21:34:53 +0100 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
On Sun, Dec 27, 2009 at 01:37:32PM +0200, Michael S. Tsirkin wrote:
> I'd like to discuss two questions related to changes that
> are committed to the shared tree.
> 1. A lot of patches are committed without being posted
> to the list first, thus they go in without review.
> Why is this good? Can this be addressed?
Most of the patches I commit without posting them first to the list are
to fix bugs on non i386 targets, as they are broken too often by people
who don't care about them.
I don't like leaving the tree broken too long so I prefer to fix that
directly. If people prefer, I can simply revert the broken patch or
series, even if sometimes it means reverting a series of 10 or more
patches.
> 2. When a change is committed to the tree, often no notification is sent
> to the author.
> Why is it a good idea to ask everyone to subscribe to qemu commits
> list as well? Can 'applied thanks' mail be sent to patch authors?
>
It something that does not really goes in my workflow, as I most often
commit a lot of patches in my local tree, and then after testing push
(some of) them.
The best would be to get the qemu commits list working again.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net
[Qemu-devel] Re: commit rules for common git tree,
Aurelien Jarno <=
- [Qemu-devel] Re: commit rules for common git tree, Michael S. Tsirkin, 2009/12/27
- [Qemu-devel] Re: commit rules for common git tree, Aurelien Jarno, 2009/12/27
- [Qemu-devel] Re: commit rules for common git tree, Michael S. Tsirkin, 2009/12/27
- [Qemu-devel] Re: commit rules for common git tree, Anthony Liguori, 2009/12/27
- [Qemu-devel] Re: commit rules for common git tree, Michael S. Tsirkin, 2009/12/28
- [Qemu-devel] Re: commit rules for common git tree, Michael S. Tsirkin, 2009/12/29
- [Qemu-devel] Re: commit rules for common git tree, Aurelien Jarno, 2009/12/29
- [Qemu-devel] Re: commit rules for common git tree, Michael S. Tsirkin, 2009/12/29
- [Qemu-devel] Re: commit rules for common git tree, Aurelien Jarno, 2009/12/29
- [Qemu-devel] Re: commit rules for common git tree, Michael S. Tsirkin, 2009/12/30