Re: [Qemu-devel] [PATCH 4/6] vnc.c: warn about ignored option

[Anthony Liguori]

On 01/26/2010 05:14 PM, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini<address@hidden>
> ---
>   vnc.c |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/vnc.c b/vnc.c
> index cc2a26e..9ebee09 100644
> --- a/vnc.c
> +++ b/vnc.c
> @@ -2563,6 +2563,7 @@ int vnc_display_open(DisplayState *ds, const char 
> *display)
>               reverse = 1;
>           } else if (strncmp(options, "to=", 3) == 0) {
>               to_port = atoi(options+3) + 5900;
> +            fprintf(stderr, "qemu: warning: to= option for -vnc ignored\n");
>    

If we're ignoring it, why even have the code?  How did clang spot this?

Regards,

Anthony Liguori