[Qemu-devel] Re: [PATCH] virtio-serial: don't set MULTIPORT for 1 port dev

[Gerd Hoffmann]

On 02/15/10 10:24, Amit Shah wrote:
> > Is there a qdev property for max_nr_ports?  Then simply adding a compat
> > property will do the trick.
>
> Something like this (I can split it into two patches before submission):

Yep, should be splitted.

> diff --git a/hw/pc.c b/hw/pc.c
> index 5b29f3b..a975934 100644
> --- a/hw/pc.c
> +++ b/hw/pc.c
> @@ -1055,12 +1055,32 @@ void cmos_set_s3_resume(void)
>   }
>
>   static QEMUMachine pc_machine = {
> +    .name = "pc-0.13",
> +    .alias = "pc",
> +    .desc = "Standard PC",
> +    .init = pc_init_pci,
> +    .is_default = 1,
> +    .max_cpus = 255,
> +};
> +
> +static QEMUMachine pc_machine_v0_12 = {
>       .name = "pc-0.12",
>       .alias = "pc",

.alias should be dropped too.

cheers,
  Gerd