[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH v4 2/5] char: Add qemu_chr_write_nb() for nonblo
From: |
Amit Shah |
Subject: |
[Qemu-devel] Re: [PATCH v4 2/5] char: Add qemu_chr_write_nb() for nonblocking writes |
Date: |
Tue, 4 May 2010 13:28:00 +0530 |
User-agent: |
Mutt/1.5.19 (2009-01-05) |
On (Tue) May 04 2010 [09:38:11], Gerd Hoffmann wrote:
> Hi,
>
>> -static int unix_write(int fd, const uint8_t *buf, int len1)
>> +static int unix_write(int fd, const uint8_t *buf, int len1, bool nonblock)
>> {
>> int ret, len;
>>
>> @@ -522,6 +537,9 @@ static int unix_write(int fd, const uint8_t *buf, int
>> len1)
>> while (len> 0) {
>> ret = write(fd, buf, len);
>> if (ret< 0) {
>> + if (errno == EAGAIN&& nonblock) {
>> + return -EAGAIN;
>> + }
>
> You've just re-introduced the bug you've fixed in patch 1/5 ...
Uh!
Amit