[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] char: Flush read buffer in mux_chr_can_read
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] [PATCH] char: Flush read buffer in mux_chr_can_read |
Date: |
Wed, 05 May 2010 17:27:28 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Move the buffer flush from mux_chr_read to mux_chr_can_read. While the
latter is called periodically, the former will only be invoked when new
characters arrive at the back-end. This caused problems to front-end
drivers whenever they were unable to read data immediately, e.g.
virtio-console attached to stdio.
Signed-off-by: Jan Kiszka <address@hidden>
---
qemu-char.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index ac65a1c..2b115a4 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -404,6 +404,8 @@ static int mux_chr_can_read(void *opaque)
MuxDriver *d = chr->opaque;
int m = d->focus;
+ mux_chr_accept_input(opaque);
+
if ((d->prod[m] - d->cons[m]) < MUX_BUFFER_SIZE)
return 1;
if (d->chr_can_read[m])
@@ -418,8 +420,6 @@ static void mux_chr_read(void *opaque, const uint8_t *buf,
int size)
int m = d->focus;
int i;
- mux_chr_accept_input (opaque);
-
for(i = 0; i < size; i++)
if (mux_proc_byte(chr, d, buf[i])) {
if (d->prod[m] == d->cons[m] &&
- Re: [Qemu-devel] [PATCH] [RESEND] Make char muxer more robust wrt small FIFOs, Anthony Liguori, 2010/05/04
- Re: [Qemu-devel] [PATCH] [RESEND] Make char muxer more robust wrt small FIFOs, Alexander Graf, 2010/05/04
- Re: [Qemu-devel] [PATCH] [RESEND] Make char muxer more robust wrt small FIFOs, Anthony Liguori, 2010/05/04
- Re: [Qemu-devel] [PATCH] [RESEND] Make char muxer more robust wrt small FIFOs, Alexander Graf, 2010/05/04
- Re: [Qemu-devel] [PATCH] [RESEND] Make char muxer more robust wrt small FIFOs, Anthony Liguori, 2010/05/04
- Re: [Qemu-devel] [PATCH] [RESEND] Make char muxer more robust wrt small FIFOs, Jan Kiszka, 2010/05/04
- [Qemu-devel] Re: [PATCH] [RESEND] Make char muxer more robust wrt small FIFOs, Jan Kiszka, 2010/05/05
- [Qemu-devel] Re: [PATCH] [RESEND] Make char muxer more robust wrt small FIFOs, Jan Kiszka, 2010/05/05
- [Qemu-devel] Re: [PATCH] [RESEND] Make char muxer more robust wrt small FIFOs, Alexander Graf, 2010/05/05
- [Qemu-devel] [PATCH] char: Flush read buffer in mux_chr_can_read,
Jan Kiszka <=
- [Qemu-devel] Re: [PATCH] char: Flush read buffer in mux_chr_can_read, Alexander Graf, 2010/05/11
- [Qemu-devel] Re: [PATCH] char: Flush read buffer in mux_chr_can_read, Jan Kiszka, 2010/05/11
- [Qemu-devel] Re: [PATCH] char: Flush read buffer in mux_chr_can_read, Alexander Graf, 2010/05/11
- [Qemu-devel] Re: [PATCH] char: Flush read buffer in mux_chr_can_read, Jan Kiszka, 2010/05/12
- [Qemu-devel] Re: [PATCH] char: Flush read buffer in mux_chr_can_read, Alexander Graf, 2010/05/14
- [Qemu-devel] Re: [PATCH] char: Flush read buffer in mux_chr_can_read, Jan Kiszka, 2010/05/14
- [Qemu-devel] Re: [PATCH] char: Flush read buffer in mux_chr_can_read, Alexander Graf, 2010/05/15
- [Qemu-devel] Re: [PATCH] char: Flush read buffer in mux_chr_can_read, Jan Kiszka, 2010/05/15
- [Qemu-devel] Re: [PATCH] char: Flush read buffer in mux_chr_can_read, Alexander Graf, 2010/05/15
- [Qemu-devel] Re: [PATCH] char: Flush read buffer in mux_chr_can_read, Jan Kiszka, 2010/05/15