[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH v2 1/6] tmp105: Drop unused faults field
From: |
andrzej zaborowski |
Subject: |
[Qemu-devel] Re: [PATCH v2 1/6] tmp105: Drop unused faults field |
Date: |
Sat, 15 May 2010 14:33:27 +0200 |
Hi Jan,
On 15 May 2010 13:32, Jan Kiszka <address@hidden> wrote:
> From: Jan Kiszka <address@hidden>
>
> It was only written, but never read.
I pushed an alternate version to just move the update from post_save
to post_load. If you think of code as documentation, the struct
becomes less complete in representing the state of the device if you
remove the register. State doesn't have to be readable through the
busses, some state may be readable through qemu monitor and the like.
Cheers
- [Qemu-devel] [PATCH v2 0/6] vmstate: Drop post_save / allow instance ID aliases, Jan Kiszka, 2010/05/15
- [Qemu-devel] [PATCH v2 3/6] vmstate: Add support for alias ID, Jan Kiszka, 2010/05/15
- [Qemu-devel] [PATCH v2 4/6] serial: Register vmstate via qdev, Jan Kiszka, 2010/05/15
- [Qemu-devel] [PATCH v2 2/6] vmstate: Drop unused post_save handler, Jan Kiszka, 2010/05/15
- [Qemu-devel] [PATCH v2 5/6] fdc: Register vmstate via qdev, Jan Kiszka, 2010/05/15
- [Qemu-devel] [PATCH v2 6/6] mc146818rtc: Register vmstate via qdev, Jan Kiszka, 2010/05/15
- [Qemu-devel] [PATCH v2 1/6] tmp105: Drop unused faults field, Jan Kiszka, 2010/05/15
- [Qemu-devel] Re: [PATCH v2 1/6] tmp105: Drop unused faults field,
andrzej zaborowski <=
- [Qemu-devel] Re: [PATCH v2 0/6] vmstate: Drop post_save / allow instance ID aliases, Blue Swirl, 2010/05/15