[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 6/7] Monitor: Return before exiting with 'quit'
From: |
Luiz Capitulino |
Subject: |
[Qemu-devel] [PATCH 6/7] Monitor: Return before exiting with 'quit' |
Date: |
Wed, 19 May 2010 13:03:01 -0300 |
This is a new version of the (now reverted) following commit:
0e8d2b5575938b8876a3c4bb66ee13c5d306fb6d
The 'quit' Monitor command (implemented by do_quit()) calls
exit() directly, this is problematic under QMP because QEMU
exits before having a chance to send the ok response.
Clients don't know if QEMU exited because of a problem or
because the 'quit' command has been executed.
This commit fixes that by making do_quit() use
qemu_system_shutdown_request(), so that we exit gracefully.
Thanks to Paolo Bonzini <address@hidden> for suggesting
this solution.
Signed-off-by: Luiz Capitulino <address@hidden>
---
monitor.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/monitor.c b/monitor.c
index 2e202ff..ad50f12 100644
--- a/monitor.c
+++ b/monitor.c
@@ -1020,7 +1020,10 @@ static void do_info_cpu_stats(Monitor *mon)
*/
static int do_quit(Monitor *mon, const QDict *qdict, QObject **ret_data)
{
- exit(0);
+ monitor_suspend(mon);
+ no_shutdown = 0;
+ qemu_system_shutdown_request();
+
return 0;
}
--
1.7.1.86.g0e460
- [Qemu-devel] [PATCH 0/7][PULL]: QMP/Monitor queue, Luiz Capitulino, 2010/05/19
- [Qemu-devel] [PATCH 1/7] QMP: Add "Downstream extension of QMP" to spec, Luiz Capitulino, 2010/05/19
- [Qemu-devel] [PATCH 2/7] Revert "PCI: Convert pci_device_hot_add() to QObject", Luiz Capitulino, 2010/05/19
- [Qemu-devel] [PATCH 3/7] Revert "monitor: Convert do_pci_device_hot_remove() to QObject", Luiz Capitulino, 2010/05/19
- [Qemu-devel] [PATCH 4/7] Revert "Monitor: Return before exiting with 'quit'", Luiz Capitulino, 2010/05/19
- [Qemu-devel] [PATCH 5/7] sysemu: Export 'no_shutdown', Luiz Capitulino, 2010/05/19
- [Qemu-devel] [PATCH 6/7] Monitor: Return before exiting with 'quit',
Luiz Capitulino <=
- [Qemu-devel] [PATCH 7/7] Fix qtypes' licenses, Luiz Capitulino, 2010/05/19