[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 1/8] block: fix aio_flush segfaults for read-only pr
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] [PATCH 1/8] block: fix aio_flush segfaults for read-only protocols (e.g. curl) |
Date: |
Thu, 20 May 2010 15:10:36 +0200 |
From: Avi Kivity <address@hidden>
Not all block format drivers expose an io_flush method (reasonable for
read-only protocols), so calling io_flush there will immediately segfault.
Fix by checking for the method's existence before calling it.
Signed-off-by: Avi Kivity <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>
---
aio.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/aio.c b/aio.c
index f164a47..2f08655 100644
--- a/aio.c
+++ b/aio.c
@@ -113,7 +113,9 @@ void qemu_aio_flush(void)
qemu_aio_wait();
QLIST_FOREACH(node, &aio_handlers, node) {
- ret |= node->io_flush(node->opaque);
+ if (node->io_flush) {
+ ret |= node->io_flush(node->opaque);
+ }
}
} while (qemu_bh_poll() || ret > 0);
}
--
1.6.6.1
- [Qemu-devel] [PULL 0/8] Block patches, Kevin Wolf, 2010/05/20
- [Qemu-devel] [PATCH 2/8] virtio-blk: Avoid zeroing every request structure, Kevin Wolf, 2010/05/20
- [Qemu-devel] [PATCH 4/8] block: fix sector comparism in multiwrite_req_compare, Kevin Wolf, 2010/05/20
- [Qemu-devel] [PATCH 3/8] virtio-blk: fix barrier support, Kevin Wolf, 2010/05/20
- [Qemu-devel] [PATCH 1/8] block: fix aio_flush segfaults for read-only protocols (e.g. curl),
Kevin Wolf <=
- [Qemu-devel] [PATCH 5/8] block: Make find_image_format() return 'raw' BlockDriver for SG_IO devices, Kevin Wolf, 2010/05/20
- [Qemu-devel] [PATCH 6/8] block: Add SG_IO device check in refresh_total_sectors(), Kevin Wolf, 2010/05/20
- [Qemu-devel] [PATCH 8/8] vvfat: More build fixes with DEBUG, Kevin Wolf, 2010/05/20
- [Qemu-devel] [PATCH 7/8] vvfat: Fix compilation with DEBUG defined, Kevin Wolf, 2010/05/20