[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 2/6] json-lexer: Handle missing escapes
From: |
Luiz Capitulino |
Subject: |
[Qemu-devel] Re: [PATCH 2/6] json-lexer: Handle missing escapes |
Date: |
Thu, 20 May 2010 12:35:39 -0300 |
On Thu, 20 May 2010 17:26:03 +0200
Paolo Bonzini <address@hidden> wrote:
> On 05/20/2010 05:25 PM, Luiz Capitulino wrote:
> > On Thu, 20 May 2010 17:16:01 +0200
> > Paolo Bonzini<address@hidden> wrote:
> >
> >> On 05/20/2010 03:44 PM, Luiz Capitulino wrote:
> >>> I think there's another issue in the handling of strings.
> >>>
> >>> The spec says that valid unescaped chars are in the following range:
> >>>
> >>> unescaped = %x20-21 / %x23-5B / %x5D-10FFFF
> >>>
> >>> But we do:
> >>>
> >>> [IN_DQ_STRING] = {
> >>> [1 ... 0xFF] = IN_DQ_STRING,
> >>> ['\\'] = IN_DQ_STRING_ESCAPE,
> >>> ['"'] = IN_DONE_STRING,
> >>> },
> >>>
> >>> Shouldn't we cover 0x20 .. 0xFF instead?
> >>
> >> If it's the lexer, isn't just it being liberal in what it accepts?
> >
> > Yes, it's the lexer, but you meant that the fix should be in
> > somewhere else?
>
> I meant that we're just accepting some invalid JSON and that's not a big
> deal.
It can become a big deal if clients rely on it and for some reason we
decide we should drop it. Ie. after QMP is declared stable such changes
won't be allowed.
Yes, I know, the chances of someone relying on this kind of thing is
probably almost zero. At the same time I think we should be very
conservative if there's no good reason to do otherwise.
- [Qemu-devel] [PATCH 0/6]: QMP: Fix issues in parser/lexer, Luiz Capitulino, 2010/05/19
- [Qemu-devel] [PATCH 1/6] json-lexer: Initialize 'x' and 'y', Luiz Capitulino, 2010/05/19
- [Qemu-devel] [PATCH 2/6] json-lexer: Handle missing escapes, Luiz Capitulino, 2010/05/19
- Re: [Qemu-devel] [PATCH 2/6] json-lexer: Handle missing escapes, Anthony Liguori, 2010/05/19
- Re: [Qemu-devel] [PATCH 2/6] json-lexer: Handle missing escapes, Luiz Capitulino, 2010/05/20
- [Qemu-devel] Re: [PATCH 2/6] json-lexer: Handle missing escapes, Paolo Bonzini, 2010/05/20
- [Qemu-devel] Re: [PATCH 2/6] json-lexer: Handle missing escapes, Luiz Capitulino, 2010/05/20
- [Qemu-devel] Re: [PATCH 2/6] json-lexer: Handle missing escapes, Paolo Bonzini, 2010/05/20
- [Qemu-devel] Re: [PATCH 2/6] json-lexer: Handle missing escapes,
Luiz Capitulino <=
- [Qemu-devel] Re: [PATCH 2/6] json-lexer: Handle missing escapes, Anthony Liguori, 2010/05/20
- [Qemu-devel] Re: [PATCH 2/6] json-lexer: Handle missing escapes, Luiz Capitulino, 2010/05/20
- [Qemu-devel] Re: [PATCH 2/6] json-lexer: Handle missing escapes, Anthony Liguori, 2010/05/20
- [Qemu-devel] Re: [PATCH 2/6] json-lexer: Handle missing escapes, Luiz Capitulino, 2010/05/20
- [Qemu-devel] Re: [PATCH 2/6] json-lexer: Handle missing escapes, Anthony Liguori, 2010/05/20
- [Qemu-devel] Re: [PATCH 2/6] json-lexer: Handle missing escapes, Luiz Capitulino, 2010/05/20
- [Qemu-devel] Re: [PATCH 2/6] json-lexer: Handle missing escapes, Anthony Liguori, 2010/05/20
- [Qemu-devel] Re: [PATCH 2/6] json-lexer: Handle missing escapes, Luiz Capitulino, 2010/05/20
- Re: [Qemu-devel] Re: [PATCH 2/6] json-lexer: Handle missing escapes, Anthony Liguori, 2010/05/24
- Re: [Qemu-devel] Re: [PATCH 2/6] json-lexer: Handle missing escapes, Luiz Capitulino, 2010/05/24