[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [Bug 584143] [NEW] qemu fails to set hdd serial number
From: |
Michael Tokarev |
Subject: |
[Qemu-devel] [Bug 584143] [NEW] qemu fails to set hdd serial number |
Date: |
Sat, 22 May 2010 09:21:04 -0000 |
Public bug reported:
The -drive ...,serial=xyz option is broken, at least in 0.12. See
Debian bug#573439, http://bugs.debian.org/cgi-
bin/bugreport.cgi?bug=573439 for details.
The proposed fix from the original reporter:
--- qemu-kvm-0.12.3+dfsg/vl.c 2010-02-26 11:34:00.000000000 +0900
+++ qemu-kvm-0.12.3+dfsg.old/vl.c 2010-03-11 02:26:00.134217787 +0900
@@ -2397,7 +2397,7 @@
dinfo->on_write_error = on_write_error;
dinfo->opts = opts;
if (serial)
- strncpy(dinfo->serial, serial, sizeof(serial));
+ strncpy(dinfo->serial, serial, sizeof(dinfo->serial));
QTAILQ_INSERT_TAIL(&drives, dinfo, next);
if (is_extboot) {
extboot_drive = dinfo;
** Affects: qemu
Importance: Undecided
Status: New
** Tags: patch
--
qemu fails to set hdd serial number
https://bugs.launchpad.net/bugs/584143
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
Status in QEMU: New
Bug description:
The -drive ...,serial=xyz option is broken, at least in 0.12. See Debian
bug#573439, http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=573439 for details.
The proposed fix from the original reporter:
--- qemu-kvm-0.12.3+dfsg/vl.c 2010-02-26 11:34:00.000000000 +0900
+++ qemu-kvm-0.12.3+dfsg.old/vl.c 2010-03-11 02:26:00.134217787 +0900
@@ -2397,7 +2397,7 @@
dinfo->on_write_error = on_write_error;
dinfo->opts = opts;
if (serial)
- strncpy(dinfo->serial, serial, sizeof(serial));
+ strncpy(dinfo->serial, serial, sizeof(dinfo->serial));
QTAILQ_INSERT_TAIL(&drives, dinfo, next);
if (is_extboot) {
extboot_drive = dinfo;
[Prev in Thread] |
Current Thread |
[Next in Thread] |