[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] sparc64: clean up pci bridge map
From: |
Igor Kovalenko |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] sparc64: clean up pci bridge map |
Date: |
Tue, 25 May 2010 23:37:17 +0400 |
On Tue, May 25, 2010 at 11:24 PM, Blue Swirl <address@hidden> wrote:
> On Tue, May 25, 2010 at 12:09 PM, Igor V. Kovalenko
> <address@hidden> wrote:
>> From: Igor V. Kovalenko <address@hidden>
>>
>> - remove unused host state and store pci bus pointer only
>> - do not map host state access into unused 1fe.10000000 range
>> - reorder pci region registration
>> - assign pci i/o region to isa_mem_base
>
> Looks good. Could you make a separate patch from the part that depends
> on OpenBIOS update and another for the cleanups? I think the cleanups
> could be applied quickly, but the OpenBIOS PCI changes may need more
> consideration.
The only real cleanup is removal of host state which becomes unusable
after mapping change. I think these changes may go in as is along with
OpenBIOS set "sparc64 cleanups v1" which supports changed address
ranges.
The PCI changes to OpenBIOS in set "encode-int related changes and pci
bus scan amendment" are separate but there is a simple dependency on
these cleanups in register mapping area.
It was probably bad idea to split OpenBIOS changes to 2 sets instead
of sending those as one series.
--
Kind regards,
Igor V. Kovalenko