[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH v4 0/10] Introduce 'info netdevices' with QMP su
From: |
Luiz Capitulino |
Subject: |
[Qemu-devel] Re: [PATCH v4 0/10] Introduce 'info netdevices' with QMP support |
Date: |
Thu, 27 May 2010 14:50:02 -0300 |
On Tue, 18 May 2010 14:07:39 -0300
Miguel Di Ciurcio Filho <address@hidden> wrote:
> The VLANClientState structure has the member info_str, a simple string that
> is filled with information about NIC devices and used on monitor calls.
>
> There is no coherent formatting of this string by all the NIC devices,
> making it difficult to parse and represent this information over QMP.
>
> To make the transition to QMP safe, we leave the current 'info network'
> command
> as is, and introduce a new one: 'info netdevices'.
Sorry for the long delay in reviewing this series..
Most important comment is: QMP development process is changing and now
it's required that any protocol change updates the qemu-monitor.hx file
with QMP info.
However, it's not merged yet so you could base your series on top of
this series, which is also in my master branch:
http://lists.gnu.org/archive/html/qemu-devel/2010-05/msg01605.html
Another option is to send the doc patch separately w/o any code and
only go back to code when there's consensus wrt new command.
Small comments on separate patches follow.
- [Qemu-devel] [PATCH v4 04/10] net: xen: introduce info_dict, (continued)
- [Qemu-devel] [PATCH v4 04/10] net: xen: introduce info_dict, Miguel Di Ciurcio Filho, 2010/05/18
- [Qemu-devel] [PATCH v4 07/10] net: dump: introduce info_dict, Miguel Di Ciurcio Filho, 2010/05/18
- [Qemu-devel] [PATCH v4 06/10] net: vde: introduce info_dict, Miguel Di Ciurcio Filho, 2010/05/18
- [Qemu-devel] [PATCH v4 05/10] net: tap/tap-win32: introduce info_dict, Miguel Di Ciurcio Filho, 2010/05/18
- [Qemu-devel] [PATCH v4 03/10] net: various devices: add qemu_format_nic_info_dict, Miguel Di Ciurcio Filho, 2010/05/18
- [Qemu-devel] [PATCH v4 02/10] net: introduce qemu_nic_format_info_dict and VLANClientState->info_dict, Miguel Di Ciurcio Filho, 2010/05/18
- [Qemu-devel] [PATCH v4 01/10] QObject API: introduce qdict_to_qstring() function, Miguel Di Ciurcio Filho, 2010/05/18
- [Qemu-devel] Re: [PATCH v4 0/10] Introduce 'info netdevices' with QMP support,
Luiz Capitulino <=