[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/4] Cleanups for block code
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH 0/4] Cleanups for block code |
Date: |
Fri, 28 May 2010 15:48:12 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100430 Fedora/3.0.4-2.fc12 Thunderbird/3.0.4 |
Am 27.05.2010 16:20, schrieb address@hidden:
> From: Jes Sorensen <address@hidden>
>
> Hi,
>
> Reading through some of the blk code, I noticed a lot of cases where
> we mix and match between hard-coded values for the block size of 512
> and using BDRV_SECTOR_SIZE. Trying to clean it up a bit and change the
> 512 constants to BDRV_SECTOR_SIZE as it is more explaning when reading
> the code.
>
> In addition it fixes up a case in bdrv_open where we did the division,
> just to multiply back to the original value for no real reason.
>
> Cheers,
> Jes
>
>
> Jes Sorensen (4):
> Cleanup: bdrv_open() no need to shift total_size just to shift back.
> Cleanup: Be consistent and use BDRV_SECTOR_SIZE instead of 512
> Cleanup: raw-posix.c: Be more consistent using BDRV_SECTOR_SIZE
> instead of 512
> Cleanup: virtio-blk.c: Be more consistent using BDRV_SECTOR_SIZE
> instead
Thanks, applied all to the block branch.
Kevin