|
| From: | Jamie Lokier |
| Subject: | Re: [Qemu-devel] Re: [PATCH V4 2/3] qemu: Generic task offloading framework: threadlets |
| Date: | Wed, 16 Jun 2010 15:22:36 +0100 |
| User-agent: | Mutt/1.5.13 (2006-08-11) |
Paolo Bonzini wrote:
> These should be (at least for now) block-obj-$(CONFIG_POSIX).
>
> >+ while (QTAILQ_EMPTY(&(queue->request_list))&&
> >+ (ret != ETIMEDOUT)) {
> >+ ret = qemu_cond_timedwait(&(queue->cond),
> >+ &(queue->lock), 10*100000);
> >+ }
>
> Using qemu_cond_timedwait is a hack for not properly broadcasting the
> condvar in flush_threadlet_queue.
Are you sure? It looks like it also expires idle threads after a
fixed amount of idle time.
-- Jamie
| [Prev in Thread] | Current Thread | [Next in Thread] |